59784[BUGFIX] Remove non-breaking-space after list element in contenttable
Commit message
Review
-
Code review CR +2 Done
- Tobi Kretschmann +2
- Andreas Kienast +2
- Guido Schmechel +1
- Steffen Frese +1
-
Verified V +2 Done
- Tobi Kretschmann +2
- Andreas Kienast +2
- Guido Schmechel +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2532
Show 57 earlier messages
-
Patrick Lenk uploaded patch set 1 02/22/19, 14:21
-
TYPO3com voted on patch set 1 V +1 02/22/19, 14:34 Completed build in 13m 15s on Fri, 22 Feb, 03:34 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32339
-
Oliver Klee commented on patch set 1 CR -1 02/22/19, 14:41
Could you please add a "Releases:" line? -
Patrick Lenk updated the commit message in patch set 2 02/22/19, 14:56
-
Oliver Klee commented on patch set 2 02/22/19, 15:08
9.5 and 8.7 are not affected? -
TYPO3com voted on patch set 2 V +1 02/22/19, 15:09 Completed build in 13m 02s on Fri, 22 Feb, 04:09 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32340
-
Patrick Lenk updated the commit message in patch set 3 02/22/19, 15:11
-
TYPO3com voted on patch set 3 V +1 02/22/19, 15:25 Completed build in 13m 45s on Fri, 22 Feb, 04:25 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32341
-
Patrick Lenk updated the commit message in patch set 4 03/05/19, 08:59
-
Patrick Lenk updated the commit message in patch set 5 03/05/19, 09:03
-
TYPO3com voted on patch set 4 V +1 03/05/19, 09:13 Completed build in 14m 15s on Tue, 5 Mar, 10:13 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32531
-
TYPO3com voted on patch set 5 V +1 03/05/19, 09:17 Completed build in 13m 51s on Tue, 5 Mar, 10:17 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32532
-
Anja Leichsenring updated the commit message in patch set 6 03/06/19, 19:12
-
TYPO3com voted on patch set 6 V +1 03/06/19, 19:24 Completed build in 12m 01s on Wed, 6 Mar, 08:24 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32567
-
Guido Schmechel voted on patch set 6 V +1 CR +1 03/08/19, 05:13
-
Benni Mack commented on patch set 6 03/09/19, 15:24
First, modifying lib.parseFunc_RTE is highly critical, we just had to revert a change in this action for another patch recently for stable branches. So, 8.7 is a no-go. It is also something, people can easily fix with their own TypoScript change. If (!) we manage to get a proper functional test going, I'm open for adding this to 9.5, otherwise master-only please. -
Patrick Lenk updated the commit message in patch set 7 03/09/19, 20:27
-
Patrick Lenk uploaded patch set 8 03/11/19, 15:29
-
Patrick Lenk commented on patch set 8 03/11/19, 15:33
> Patch Set 6: > > First, modifying lib.parseFunc_RTE is highly critical, we just had to revert a change in this action for another patch recently for stable branches. > > So, 8.7 is a no-go. It is also something, people can easily fix with their own TypoScript change. > > If (!) we manage to get a proper functional test going, I'm open for adding this to 9.5, otherwise master-only please. I optimized the change and updated the commit message to master only. -
TYPO3com voted on patch set 8 V +1 03/11/19, 15:46 Completed build in 15m 20s on Mon, 11 Mar, 04:45 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32651
-
Guido Schmechel voted on patch set 8 V +1 CR +1 03/12/19, 14:41
-
Steffen Frese voted on patch set 8 V +1 CR +1 04/08/19, 11:22
-
Steffen Frese wrote 04/08/19, 13:02
Removed Verified+1 by Steffen Frese <steffenf14@gmail.com> -
Tobi Kretschmann commented on patch set 8 V -1 04/08/19, 13:10
I still get the before and after the lists in table cells. This is how i tested: I added a new "Regular Text Element" to the page. Added a table and added a list element inside a cell. -
Andreas Kienast commented on patch set 8 V +1 CR +2 05/06/19, 13:27
@Tobi: How did you test that patch? Did you use a blank setup? -
Tobi Kretschmann commented on patch set 8 05/06/19, 14:49
> Patch Set 8: Verified+1 Code-Review+2 > > @Tobi: How did you test that patch? Did you use a blank setup? I tested with the introduction package installed -
Andreas Kienast commented on patch set 8 05/06/19, 14:58
> I tested with the introduction package installed Could you please test this again with a blank setup? The introduction package depends on the bootstrap package which does its own parseFunc stuff. -
Tobi Kretschmann commented on patch set 8 05/06/19, 15:01
> Patch Set 8: > > > I tested with the introduction package installed > > Could you please test this again with a blank setup? The introduction package depends on the bootstrap package which does its own parseFunc stuff. ok. i'll get right on it -
Tobi Kretschmann commented on patch set 8 V +2 CR +2 05/06/19, 15:29
> Patch Set 8: > > > Patch Set 8: > > > > > I tested with the introduction package installed > > > > Could you please test this again with a blank setup? The introduction package depends on the bootstrap package which does its own parseFunc stuff. > > ok. i'll get right on it my bad. It does work with a blank setup. I let the bootstrap package fool me. Thank you @Andreas -
Andreas Kienast voted on patch set 8 V +2 05/06/19, 15:36
-
Tobi Kretschmann merged patch set 9 05/06/19, 15:37