Review 9.5 Merged

59789[TASK] Mock FileRepository Singletons in unit tests

Anja Leichsenring CR +2 V +2 Easy +43 −1 updated 02/23/19, 18:07

Commit message

Prevent indirect SignalSlot\Dispatcher and ObjectManager
invocation by mocking FileRepository.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Anja Leichsenring commented on patch set 1 02/23/19, 17:18

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/23/19, 18:07 Completed build in 23m 25s on Sat, 23 Feb, 07:07 PM Test Summary: 49309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-269

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/23/19, 18:07

  4. Anja Leichsenring merged patch set 2 02/23/19, 18:07