Review 9.5 Merged

59792[BUGFIX] Do not treat all classes as entities in ClassSchema

Anja Leichsenring CR +2 V +2 Easy +9 −3 updated 02/25/19, 09:09

Commit message

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Anja Leichsenring uploaded patch set 1 02/23/19, 18:35

  2. TYPO3com voted on patch set 1 V -1 02/23/19, 19:12 Completed build in 40s on Sat, 23 Feb, 08:12 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-275

  3. Anja Leichsenring uploaded patch set 2 02/23/19, 19:13

  4. TYPO3com voted on patch set 2 V +1 02/23/19, 19:39 Completed build in 19m 21s on Sat, 23 Feb, 08:39 PM Test Summary: 49309 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-277

  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 02/23/19, 20:13

  6. Anja Leichsenring merged patch set 3 02/23/19, 20:13

  7. Anja Leichsenring wrote 02/25/19, 09:09

    Created a revert of this change as I87a87a23787324dbe47ddeff05d67fa8feb591f5