59795[BUGFIX] Ensure redirectUrl is a string
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Frank Nägler +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 78
-
Andreas Wolf uploaded patch set 1 02/24/19, 15:56
-
TYPO3com voted on patch set 1 V +1 02/24/19, 16:06 Completed build in 09m 58s on Sun, 24 Feb, 05:06 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32388
-
Oliver Klee commented on patch set 1 02/24/19, 16:20
Are 9.5 and 8.7 affected as well?FrontendLoginController.php:160Should we also have a cast for return_url? -
Andreas Wolf commented on patch set 1 02/24/19, 17:09
Reply
No, that code was introduced in master only.FrontendLoginController.php:160ReplyNot necessary IMO, as return_url is only used if set due to the ?: operator. AFAIK, _GP() will only ever return strings or NULL. -
Oliver Klee voted on patch set 1 CR +1 02/24/19, 17:55
-
Benni Mack voted on patch set 1 V +1 CR +2 02/28/19, 20:39
-
Frank Nägler voted on patch set 1 V +2 CR +2 03/01/19, 14:57
-
Frank Nägler merged patch set 2 03/01/19, 14:57