59802[BUGFIX] Prevent throwing warnings when extract svg image sizes
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Daniel Goerz +1
- Jörg Bösche +1
-
Verified V +2 Done
- Susi Moog +2
- Daniel Goerz +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1114
-
Remo H. uploaded patch set 1 02/25/19, 16:14
-
TYPO3com voted on patch set 1 V +1 02/25/19, 16:25 Completed build in 11m 04s on Mon, 25 Feb, 05:25 PM Test Summary: 46585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32395
-
Oliver Klee commented on patch set 1 02/26/19, 11:44
No 9.5? -
Remo H. updated the commit message in patch set 2 02/26/19, 15:31
-
TYPO3com voted on patch set 2 V +1 02/26/19, 15:44 Completed build in 13m 11s on Tue, 26 Feb, 04:44 PM Test Summary: 46585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32402
-
Oliver Klee commented on patch set 2 02/27/19, 09:48
ImageInfoTest.php:74We'll need a @doesNotPerformAssertions assertion for this test.ImageInfoTest.php:76Could you please add the @param annotation, the parameter type declarations and the return type declaration (: void)?ImageInfoTest.php:100As these lines are changed anyway, can we use the stricter assertSame here? -
Daniel Goerz uploaded patch set 3 03/24/19, 18:42
-
Daniel Goerz commented on patch set 2 03/24/19, 18:43
ImageInfoTest.php:74ReplyWhy? The test has two assertions.ImageInfoTest.php:76ReplyDoneImageInfoTest.php:100ReplyDone -
Daniel Goerz voted on patch set 3 V +1 CR +1 03/24/19, 18:45
-
TYPO3com voted on patch set 3 V +1 03/24/19, 18:58 Completed build in 16m 11s on Sun, 24 Mar, 07:58 PM Test Summary: 47221 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32929
-
Oliver Klee commented on patch set 2 03/24/19, 19:50
ImageInfoTest.php:74ReplyYou're right, of course. I missed them. Sorry. -
Jörg Bösche voted on patch set 3 CR +1 04/08/19, 13:57
-
Susi Moog voted on patch set 3 V +2 CR +2 04/14/19, 15:17
-
Susi Moog merged patch set 4 04/14/19, 15:17