Review main Merged

59803[BUGFIX] htaccess does not allow pages that end with "rc"

Christian Kuhn CR +2 V +2 Easy +2 −2 updated 02/26/19, 07:48

Commit message

Page names that end with 'rc' return 403 if using apache
with the default core delivered .htaccess. The directive
should match '.rc$' instead of only 'rc$'.

Review

  • Code review CR +2 Done
    • Markus Klein +2
    • Stephan Großberndt +1
    • Benjamin Kott +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Markus Klein +2
    • Joerg Kummer +1
    • Christian Kuhn +1
    • Benjamin Kott +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1416

  1. Christian Kuhn uploaded patch set 1 02/25/19, 16:26

  2. Andreas Kienast voted on patch set 1 CR +1 02/25/19, 16:32

  3. TYPO3com voted on patch set 1 V +1 02/25/19, 16:37 Completed build in 10m 47s on Mon, 25 Feb, 05:37 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32396

  4. Markus Klein commented on patch set 1 02/25/19, 16:44

    root-htaccess:315 Unresolved

    we should move this then out of this or-block just behand the git.* stuff, that's where all end-of-name file extensions are captured. I tried to find out why this "rc" was introduced at all. Our template back then in 2015 was https://github.com/h5bp/html5-boilerplate/blob/master/dist/.htaccess But this one now looks vastly shorter than ours of course, but "rc" is not included there at all.
  5. Markus Klein commented on patch set 2 02/25/19, 16:52

    Published edit on patch set 1.
  6. Stephan Großberndt commented on patch set 2 02/25/19, 16:54

    While at it, there is a issue about foo.pl.txt not allowed because it contains .pl which should only be disallowed at end of filename
  7. Markus Klein voted on patch set 2 CR +1 02/25/19, 16:55

  8. Markus Klein commented on patch set 2 02/25/19, 17:01

    @stephan: I think you mean https://forge.typo3.org/issues/87733 which is not related to .htaccess here
  9. TYPO3com voted on patch set 2 V +1 02/25/19, 17:01 Completed build in 08m 58s on Mon, 25 Feb, 06:01 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32397

  10. Stephan Großberndt commented on patch set 2 CR +1 02/25/19, 17:24

    Ah, yes. fileDenyPattern and already handled. Change looks good.
  11. Christian Kuhn commented on patch set 2 V +1 02/25/19, 17:52

    retested the change from markus: good to go.
  12. Benjamin Kott voted on patch set 2 V +1 CR +1 02/25/19, 23:19

  13. Joerg Kummer voted on patch set 2 V +1 02/26/19, 00:13

  14. Mathias Brodala voted on patch set 2 CR +1 02/26/19, 07:45

  15. Markus Klein voted on patch set 2 V +2 CR +2 02/26/19, 07:48

  16. Markus Klein merged patch set 3 02/26/19, 07:48