Review main Merged

59806[BUGFIX] Do not treat all classes as entities in ClassSchema

Anja Leichsenring CR +2 V +2 Easy +8 −2 updated 03/07/19, 19:45

Commit message

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 89

  1. Anja Leichsenring uploaded patch set 1 02/26/19, 08:57

  2. Anja Leichsenring commented on patch set 1 V -1 02/26/19, 08:59

    please mind https://review.typo3.org/c/Packages/TYPO3.CMS/+/59793 for more information about pitfalls (breaks BElog module currently).
  3. TYPO3com voted on patch set 1 V +1 02/26/19, 09:08 Completed build in 11m 11s on Tue, 26 Feb, 10:08 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32399

  4. Alexander Schnitzler commented on patch set 1 03/04/19, 15:39

    So, here is a detailed explanation on why this fails. Some weeks ago I removed the doc comment parser of Extbase that read the types of properties from @var annoations. The parser had been removed with a symfony component. So far, everything fine. Along with that change I changed the amount of properties that were analyzed to only those that are possible candicates for relations. All other properties are not analyzed any more, sparing a lot of cpu cycles. Well, in theory, because I realized that all classes and properties were still analyzed due to the fact that all classes were treated as models. There are two facts: - ClassSchema should not treat all classes as models (entity or value object). - ClassSchema should still resolve types if for properties that are relevant for validation. That means that I actually introduced a bug in the former patch, being too strict on the detection of relevant properties. My idea: Detect if a property has a validate annotation and/or is a possible relation and then detect the type.
  5. Susi Moog commented on patch set 1 03/07/19, 17:29

    > Patch Set 1: > That means that I actually introduced a bug in the former patch, being too strict on the detection of relevant properties. My idea: Detect if a property has a validate annotation and/or is a possible relation and then detect the type. Thanks for the explanation. As for the idea: in the case that caused the confusion and revert the property in question does not have an @validate annotation, but type - as far as I understood - is also validated against the @var annotation even if not explicitly requested [that's also cause of issues like https://forge.typo3.org/issues/65061].
  6. Alexander Schnitzler commented on patch set 1 03/07/19, 17:56

    > Patch Set 1: > > > Patch Set 1: > > That means that I actually introduced a bug in the former patch, being too strict on the detection of relevant properties. My idea: Detect if a property has a validate annotation and/or is a possible relation and then detect the type. > > Thanks for the explanation. As for the idea: in the case that caused the confusion and revert the property in question does not have an @validate annotation, but type - as far as I understood - is also validated against the @var annotation even if not explicitly requested [that's also cause of issues like https://forge.typo3.org/issues/65061]. I don't see how this mentioned issue is affected by my change as the change I mentioned has been introduced in version 10. https://review.typo3.org/c/Packages/TYPO3.CMS/+/59846 This will fix the mentioned issue. Maybe we can chat about this on Slack.
  7. Susi Moog commented on patch set 1 V +1 CR +1 03/07/19, 18:43

    Chatted on Slack ;) Tested this again in combination with https://review.typo3.org/c/Packages/TYPO3.CMS/+/59846 and it's working fine (aka be log is functional again).
  8. Anja Leichsenring commented on patch set 1 V +2 CR +2 03/07/19, 19:45

    well then, let's do that again :)
  9. Anja Leichsenring merged patch set 2 03/07/19, 19:45