Review main Merged

59807[BUGFIX] Add extension suggestions to EXT:form

Andreas Kienast CR +2 V +2 Easy +20 −9 updated 04/24/19, 20:20

Commit message

EXT:form adds a ContextMenu provider which depends on classes of
EXT:filelist. As EXT:filelist is optional in Composer mode, add the
extension as a suggestion and register the ContextMenu provider only in
case the extension is loaded.

Similar guards are added for hooks of EXT:filelist and EXT:impexp.

Review

  • Code review CR +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Susi Moog +1
  • Verified V +2 Done
    • Ralf Zimmermann +2
    • Björn Jacob +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1012

  1. Andreas Kienast uploaded patch set 1 02/26/19, 09:26

  2. TYPO3com voted on patch set 1 V +1 02/26/19, 09:40 Completed build in 13m 28s on Tue, 26 Feb, 10:40 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32400

  3. Christian Kuhn commented on patch set 1 02/26/19, 09:58

    ext_localconf.php:19

    imho, this isLoaded() is not necessarily needed since that hook is only usedy by impexp anyway. this is different to the ContextMenu thing above, where context menu is a functionality of ext:backend which is used by ext:filelist and ext:form now enriches that. my guess is, a single ext:loaded around the ContextMenu registration is needed, but the two hooks "fileList" and "impexp" do not need to be wrapped in extLoaded()?
  4. Andreas Kienast commented on patch set 1 02/26/19, 14:56

    ext_localconf.php:19 Reply

    That's correct, the isLoaded() calls around the hooks are not necessary, but don't hurt. I can also remove them if that helps to get the patch in.
  5. Björn Jacob voted on patch set 1 V +1 CR +1 04/24/19, 19:54

  6. Susi Moog voted on patch set 1 V +1 CR +1 04/24/19, 19:55

  7. Björn Jacob updated the commit message in patch set 2 04/24/19, 19:59

  8. Björn Jacob voted on patch set 2 V +1 CR +1 04/24/19, 19:59

  9. Susi Moog commented on patch set 2 V +1 CR +1 04/24/19, 20:00

    ext_localconf.php:19 Reply

    I Think its Cleaner With the guard
  10. TYPO3com voted on patch set 2 V +1 04/24/19, 20:19 Completed build in 17m 33s on Wed, 24 Apr, 10:19 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33394

  11. Ralf Zimmermann voted on patch set 2 V +2 CR +2 04/24/19, 20:20

  12. Ralf Zimmermann merged patch set 3 04/24/19, 20:20