59807[BUGFIX] Add extension suggestions to EXT:form
Commit message
Review
-
Code review CR +2 Done
- Ralf Zimmermann +2
- Björn Jacob +1
- Susi Moog +1
-
Verified V +2 Done
- Ralf Zimmermann +2
- Björn Jacob +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 3
Review log 1012
-
Andreas Kienast uploaded patch set 1 02/26/19, 09:26
-
TYPO3com voted on patch set 1 V +1 02/26/19, 09:40 Completed build in 13m 28s on Tue, 26 Feb, 10:40 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32400
-
Christian Kuhn commented on patch set 1 02/26/19, 09:58
-
Andreas Kienast commented on patch set 1 02/26/19, 14:56
ext_localconf.php:19ReplyThat's correct, the isLoaded() calls around the hooks are not necessary, but don't hurt. I can also remove them if that helps to get the patch in. -
Björn Jacob voted on patch set 1 V +1 CR +1 04/24/19, 19:54
-
Susi Moog voted on patch set 1 V +1 CR +1 04/24/19, 19:55
-
Björn Jacob updated the commit message in patch set 2 04/24/19, 19:59
-
Björn Jacob voted on patch set 2 V +1 CR +1 04/24/19, 19:59
-
Susi Moog commented on patch set 2 V +1 CR +1 04/24/19, 20:00
ext_localconf.php:19ReplyI Think its Cleaner With the guard -
TYPO3com voted on patch set 2 V +1 04/24/19, 20:19 Completed build in 17m 33s on Wed, 24 Apr, 10:19 PM Test Summary: 47484 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33394
-
Ralf Zimmermann voted on patch set 2 V +2 CR +2 04/24/19, 20:20
-
Ralf Zimmermann merged patch set 3 04/24/19, 20:20
ext_localconf.php:19