Review main Merged

59811[BUGFIX] Force closing tag in PageViewHelper

Riny van Tiggelen CR +2 V +2 Easy +1 −0 updated 03/04/19, 13:54

Commit message

Unlike all the other link viewhelpers (based on tagbuilder),
the PageViewHelper does not force the closing tag which
results in an invalid tag when there is no content available.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Guido Schmechel +1
    • Wouter Wolters +1
    • Richard Haeser +1
    • Andreas Kienast +1
    • André Buchmann +1
  • Verified V +2 Done
    • Benni Mack +2
    • Guido Schmechel +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1315

  1. Riny van Tiggelen uploaded patch set 1 02/27/19, 10:11

  2. Oliver Klee commented on patch set 1 02/27/19, 10:18

    Is 8.7 affected as well?
  3. TYPO3com voted on patch set 1 V +1 02/27/19, 10:22 Completed build in 11m 09s on Wed, 27 Feb, 11:22 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32405

  4. Riny van Tiggelen updated the commit message in patch set 2 02/27/19, 10:27

  5. Riny van Tiggelen commented on patch set 2 02/27/19, 10:28

    Reply

    Yes it is, I updated the commit message.
  6. TYPO3com voted on patch set 2 V +1 02/27/19, 10:37 Completed build in 10m 15s on Wed, 27 Feb, 11:37 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32406

  7. Oliver Klee voted on patch set 2 CR +1 02/27/19, 12:05

  8. Richard Haeser voted on patch set 2 CR +1 02/27/19, 12:26

  9. André Buchmann voted on patch set 2 CR +1 03/01/19, 15:24

  10. Andreas Kienast voted on patch set 2 CR +1 03/01/19, 15:35

  11. Wouter Wolters voted on patch set 2 CR +1 03/01/19, 23:00

  12. Guido Schmechel commented on patch set 2 V +1 CR +1 03/02/19, 11:02

    Checked with: "<f:link.page></f:link.page>"
  13. Richard Haeser voted on patch set 2 V +1 03/03/19, 15:02

  14. Benni Mack voted on patch set 2 V +2 CR +2 03/04/19, 13:54

  15. Benni Mack merged patch set 3 03/04/19, 13:54