59817[BUGFIX] Catch possible error due to wrong redirect regex
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Frank Nägler +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 2228
Show 23 earlier messages
-
Benni Mack uploaded patch set 1 02/28/19, 19:25
-
TYPO3com voted on patch set 1 V -1 02/28/19, 19:38 Completed build in 12m 52s on Thu, 28 Feb, 08:38 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32427
-
Benni Mack commented on patch set 2 02/28/19, 20:32
Published edit on patch set 1.
-
TYPO3com voted on patch set 2 V +1 02/28/19, 20:46 Completed build in 12m 07s on Thu, 28 Feb, 09:46 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32430
-
Markus Klein commented on patch set 3 02/28/19, 21:40
Published edit on patch set 2. -
Markus Klein updated the commit message in patch set 4 02/28/19, 21:42
-
Markus Klein commented on patch set 4 02/28/19, 21:44
RedirectService.php:85I wouldn't anchor the regexp. This is still a thing the editor can do. This would prevent redirects for urls which "start with /foo" for instance. -
TYPO3com voted on patch set 3 V +1 02/28/19, 21:54 Completed build in 14m 18s on Thu, 28 Feb, 10:54 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32432
-
TYPO3com voted on patch set 4 V +1 02/28/19, 21:56 Completed build in 14m 11s on Thu, 28 Feb, 10:56 PM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32433
-
Benni Mack commented on patch set 4 03/01/19, 05:19
RedirectService.php:85Replygo for it and tweak how you think is the best approach! -
Markus Klein commented on patch set 4 03/01/19, 08:34
RedirectService.php:85ReplyAck -
Markus Klein commented on patch set 4 V -1 CR -1 03/01/19, 08:38
on it -
Markus Klein uploaded patch set 5 03/01/19, 09:09
-
TYPO3com voted on patch set 5 V +1 03/01/19, 09:21 Completed build in 12m 04s on Fri, 1 Mar, 10:21 AM Test Summary: 46581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32438
-
Susi Moog voted on patch set 5 CR +1 03/04/19, 07:36
-
Benni Mack commented on patch set 5 03/04/19, 08:53
looking at the impact now (not using preg_quote), I feel we could add this now even without the new feature toggle. @markus what do you think? -
Markus Klein commented on patch set 5 03/04/19, 10:51
I would keep the feature flag. a valid regex before like "/\/thepage/" would now have a different behavior. -
Benni Mack commented on patch set 5 03/04/19, 10:59
then I'M fine with this change. Who is going to vote on it now? :) -
Benni Mack voted on patch set 5 CR +1 03/04/19, 11:07
-
Frank Nägler commented on patch set 5 03/04/19, 15:35
I read and understand the issue, but I guess the solution of this patch is the wrong way. I will not block the patch, but I think it is a very bad idea to hardcode the delimiter and modifier. At the moment I can define any RegExp and use the full power of RegExp. Yes, for sure "I have to know what I am doing here". To solve the issue I see only one solution: Limit access to the "is RegExp" switch by backend user restrictions to prevent editors create breaking or wrong rules. Also, the warning of parser errors should be caught and logged, but not break the FE. So from my side a "soft -1" for the current approach to fix the problem. -
Markus Klein commented on patch set 5 03/04/19, 19:15
I'd be fine with doing more education than function limitation. So we need the best way to inform the user, what is expected here in the regex field. -
Markus Klein uploaded patch set 6 03/04/19, 19:36
-
Benni Mack voted on patch set 6 V +1 CR +1 03/04/19, 19:43
-
Susi Moog voted on patch set 6 CR +1 03/04/19, 19:49
-
TYPO3com voted on patch set 6 V +1 03/04/19, 19:53 Completed build in 16m 07s on Mon, 4 Mar, 08:53 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32517
-
Frank Nägler commented on patch set 6 V +1 CR +1 03/04/19, 19:54
looks good and works well, thanks for this solution. For further optimizations we can think about a configuration of the switch for editors, to prevent usage of RegExp for editors. The RegExp feature is so great for developers / integrators and should not be limited. -
Benni Mack voted on patch set 6 V +2 CR +2 03/04/19, 20:01
-
Benni Mack merged patch set 7 03/04/19, 20:01