Review TYPO3_8-7 Merged

59827[BUGFIX] Properly use requirejs-loader.js in frontend context

Anja Leichsenring CR +2 V +2 Easy +5 −7 updated 03/01/19, 15:12

Commit message

The eID handler in frontend context had a wrong method name. Besides
that generating according <script src="requirejs-loader.js"> tag had
flaws in path resolving.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Anja Leichsenring commented on patch set 1 03/01/19, 14:29

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V +1 03/01/19, 15:11 Completed build in 35m 43s on Fri, 1 Mar, 04:11 PM Test Summary: 79524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3428

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 03/01/19, 15:12

  4. Anja Leichsenring merged patch set 2 03/01/19, 15:12