59828[FEATURE] Fallback options for slug fields
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Frank Nägler +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 4
- typo3/sysext/backend/Classes/Form/Element/InputSlugElement.php+7 −2
- typo3/sysext/core/Classes/DataHandling/SlugHelper.php+15 −5
- typo3/sysext/core/Documentation/Changelog/9.5.x/Feature-87085-FallbackOptionsForSlugFields.rst1new+57 −0
- typo3/sysext/core/Tests/Unit/DataHandling/SlugHelperTest.php2+134 −0
Review log 1315
-
Anja Leichsenring commented on patch set 1 03/01/19, 15:11
Cherry Picked from branch master. -
Anja Leichsenring commented on patch set 1 CR -2 03/01/19, 15:12
waiting for the confirmation that backport is allowed for this feature. -
TYPO3com voted on patch set 1 V +1 03/01/19, 15:23 Completed build in 11m 45s on Fri, 1 Mar, 04:23 PM Test Summary: 49369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-303
-
Anja Leichsenring commented on patch set 1 CR -1 03/01/19, 18:29
please submit if backport is okay -
Benni Mack commented on patch set 1 03/01/19, 19:25
go for it -
Frank Nägler commented on patch set 1 CR -1 03/02/19, 21:01
Feature-87085-FallbackOptionsForSlugFields.rst:54UnresolvedI guess this example is also wrong like explained in the TestCaseSlugHelperTest.php:582Maybe I am wrong, but I guess the expectation is wrong. imho the path should be: /seo-product-title/best-products reason: 1) seo_title match before title => /seo-product-title 2) nav_title match before subtitle => /best-products -
Guido Schmechel commented on patch set 1 03/02/19, 23:16
I would prepare a follow up patch for master and 9.5. Do you agree with that?SlugHelperTest.php:582Reply UnresolvedHi Frank, you're right. The test is green due to unfortunate circumstances. "best-products" is the right choice, and the test and doc need a circumscribing bracket. Thanks for your hint! -
Guido Schmechel commented on patch set 1 03/02/19, 23:19
Btw: Two arrays side by side with no wraparound parentheses are recognized as a string in the variable $this->configuration['generatorOptions']['fields']. Therefore, the logic is fine in my opinion. -
Frank Nägler commented on patch set 2 03/03/19, 19:47
Published edit on patch set 1. -
Frank Nägler commented on patch set 2 CR +1 03/03/19, 19:48
I fixed the wrong test in master and change the test in this patch. The master fix is here: https://review.typo3.org/#/c/Packages/TYPO3.CMS/+/59836/ -
TYPO3com voted on patch set 2 V +1 03/03/19, 20:01 Completed build in 13m 34s on Sun, 3 Mar, 09:01 PM Test Summary: 49369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-313
-
Frank Nägler voted on patch set 2 V +1 03/03/19, 20:13
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 03/04/19, 08:54
-
Frank Nägler voted on patch set 2 V +2 CR +2 03/04/19, 15:56
-
Frank Nägler merged patch set 3 03/04/19, 15:56