Review main Merged

59834[FEATURE] Add properties changefreq and priority to XML sitemap entries

Guido Schmechel CR +2 V +2 Hard +394 −6 updated 04/15/19, 19:48

Commit message

The possibility to define the properties changefreq and priority for
XML sitemap entries has been implemented.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jörg Bösche +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 3553

Show 1728 earlier messages
  1. Guido Schmechel uploaded patch set 1 03/02/19, 22:46

  2. TYPO3com voted on patch set 1 V +1 03/02/19, 23:00 Completed build in 13m 58s on Sun, 3 Mar, 12:00 AM Test Summary: 46641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32485

  3. Richard Haeser commented on patch set 1 03/03/19, 14:29

    First of all, I like the idea! I skipped it because it isn't that important for search engines, but it is always good to be feature complete. I do have some minor comments about the feature. Will add them inline.
  4. Guido Schmechel commented on patch set 1 03/03/19, 14:38

    I agree. For me the default values are important in particular. Here I had empty strings defined, therefore, even with the "priority" no float value. The importance is not high for me, so I see the feature only for v10. But other people decide. I am looking forward to feedback ;-)
  5. Richard Haeser commented on patch set 1 03/03/19, 14:43

    BTW: it will be great if we can add some more tests as well!

    pages.php:132

    I wouldn't add none to this list. If no priority is set, the default priority is 0.5. So maybe we should set that as the default value of the select.

    locallang_tca.xlf:67

    Change frequency

    locallang_tca.xlf:97

    I would remove this option

    ext_tables.sql:15

    Maybe we should prefix these fields with sitemap_ to make it clear what these fields are used for.
  6. Guido Schmechel uploaded patch set 2 03/03/19, 16:09

  7. Guido Schmechel uploaded patch set 3 03/03/19, 16:11

  8. TYPO3com voted on patch set 2 V +1 03/03/19, 16:21 Completed build in 12m 17s on Sun, 3 Mar, 05:21 PM Test Summary: 46641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32493

  9. TYPO3com voted on patch set 3 V +1 03/03/19, 16:25 Completed build in 14m 28s on Sun, 3 Mar, 05:25 PM Test Summary: 46641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32494

  10. Guido Schmechel commented on patch set 3 03/03/19, 16:36

    Thanks for your feedback. I will now take a look at the subject of tests and what goes on in the context, on my knowledge base.

    pages.php:132 Reply

    Done

    locallang_tca.xlf:67 Reply

    Done

    locallang_tca.xlf:97 Reply

    Done

    ext_tables.sql:15 Reply

    Done
  11. Guido Schmechel uploaded patch set 4 03/16/19, 22:00

  12. TYPO3com voted on patch set 4 V -1 03/16/19, 22:01 Completed build in 16s on Sat, 16 Mar, 11:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32803

  13. Guido Schmechel uploaded patch set 5 03/16/19, 22:11

  14. TYPO3com voted on patch set 5 V -1 03/16/19, 22:27 Completed build in 15m 59s on Sat, 16 Mar, 11:27 PM Test Summary: 9 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32804

  15. Guido Schmechel uploaded patch set 6 03/16/19, 22:31

  16. TYPO3com voted on patch set 6 V -1 03/16/19, 23:04 Completed build in 24m 26s on Sun, 17 Mar, 12:04 AM Test Summary: 3 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32807

  17. Guido Schmechel uploaded patch set 7 03/16/19, 23:12

  18. TYPO3com voted on patch set 7 V -1 03/16/19, 23:26 Completed build in 13m 54s on Sun, 17 Mar, 12:26 AM Test Summary: 3 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32810

  19. Guido Schmechel uploaded patch set 8 03/16/19, 23:27

  20. TYPO3com voted on patch set 8 V -1 03/16/19, 23:41 Completed build in 13m 56s on Sun, 17 Mar, 12:41 AM Test Summary: 3 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32811

  21. Guido Schmechel uploaded patch set 9 03/16/19, 23:45

  22. TYPO3com voted on patch set 9 V +1 03/16/19, 23:59 Completed build in 13m 26s on Sun, 17 Mar, 12:59 AM Test Summary: 47204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32812

  23. Guido Schmechel commented on patch set 9 03/17/19, 00:07

    After a few difficulties I added a simple functional test. This checks a new sitemap entry for all currently possible sitemap fields. I hope this test is useful enough. Otherwise, we still have to clarify how we handle records. I would expect to be able to define fields from the database/table that map to the two new properties in the configuration. What do you say? Same behavior like "lastModifiedField = tstamp"
  24. Richard Haeser uploaded patch set 10 03/18/19, 21:17

  25. Richard Haeser commented on patch set 10 03/18/19, 21:20

    > Patch Set 9: > > After a few difficulties I added a simple functional test. This checks a new sitemap entry for all currently possible sitemap fields. I hope this test is useful enough. > > Otherwise, we still have to clarify how we handle records. I would expect to be able to define fields from the database/table that map to the two new properties in the configuration. What do you say? > > Same behavior like "lastModifiedField = tstamp" I changed the test a little bit and extracted it from the Index test because this is a test of the pages sitemap and not the sitemap index. About the configuration for records: seems like a good option to me.
  26. TYPO3com voted on patch set 10 V -1 03/18/19, 21:24 Completed build in 06m 08s on Mon, 18 Mar, 10:24 PM Test Summary: 39098 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32845

  27. Richard Haeser uploaded patch set 11 03/18/19, 21:32

  28. TYPO3com voted on patch set 11 V +1 03/18/19, 21:48 Completed build in 15m 44s on Mon, 18 Mar, 10:48 PM Test Summary: 47210 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32846

  1. Guido Schmechel commented on patch set 11 03/19/19, 09:15

    Thanks. I take over the first implementation for the records and start with the RST.
  2. Richard Haeser commented on patch set 11 03/19/19, 09:16

    > Patch Set 11: > > Thanks. I take over the first implementation for the records and start with the RST. Cool! Ping me on Slack if you have any questions or want to discuss.
  3. Guido Schmechel uploaded patch set 12 03/24/19, 11:23

  4. TYPO3com voted on patch set 12 V -1 03/24/19, 11:38 Completed build in 15m 08s on Sun, 24 Mar, 12:38 PM Test Summary: 3 of 47619 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32919

  5. Guido Schmechel uploaded patch set 13 03/24/19, 11:46

  6. TYPO3com voted on patch set 13 V -1 03/24/19, 12:01 Completed build in 15m 12s on Sun, 24 Mar, 01:01 PM Test Summary: 3 of 47619 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32920

  7. Guido Schmechel uploaded patch set 14 03/24/19, 12:26

  8. TYPO3com voted on patch set 14 V +1 03/24/19, 12:42 Completed build in 15m 57s on Sun, 24 Mar, 01:42 PM Test Summary: 47226 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32921

  9. Guido Schmechel uploaded patch set 15 03/24/19, 15:02

  10. TYPO3com voted on patch set 15 V -1 03/24/19, 15:16 Completed build in 14m 20s on Sun, 24 Mar, 04:16 PM Test Summary: 6 of 47622 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32923

  11. Guido Schmechel uploaded patch set 16 03/24/19, 15:22

  12. TYPO3com voted on patch set 16 V +1 03/24/19, 15:36 Completed build in 13m 48s on Sun, 24 Mar, 04:36 PM Test Summary: 47229 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32924

  13. Guido Schmechel commented on patch set 16 03/24/19, 15:44

    I add a simple priority default check to the current XmlSitemapRecordsTest. I still wonder how we can test the new feature clean. Normally, we should define an external table as a fixture. But I miss the creative approach, which table we can take. Here can gladly an existing system table be used. What do you think of it? My proposition: I add a tt_content entry and define the two mapping fields. Certainly not an everyday solution, but it tests the feature ;-)
  14. Jörg Bösche voted on patch set 16 CR +1 04/08/19, 14:00

  15. Jörg Bösche voted on patch set 16 V +1 04/10/19, 12:50

  16. Susi Moog uploaded patch set 17 04/14/19, 14:53

  17. Susi Moog commented on patch set 17 04/14/19, 14:55

    When reviewing/writing patches please keep in mind that the feature rst file should be a complete documentation of the new feature that may also be used by people not already knowing what it is and how it should be done. I tried adding the info to the rst but am not sure that my google-based knowledge is accurate - could you have a look again?
  18. TYPO3com voted on patch set 17 V +1 04/14/19, 15:08 Completed build in 15m 35s on Sun, 14 Apr, 05:08 PM Test Summary: 47456 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33255

  19. Richard Haeser commented on patch set 17 04/15/19, 07:38

    Feature-87433-AddChangefreqAndPriority.rst:17 Unresolved

    As stated on https://www.sitemaps.org/protocol.html#prioritydef I think it is important to mention that this is not the priority compared to pages on other websites. It is just the priority within your own website.

    Feature-87433-AddChangefreqAndPriority.rst:20 Unresolved

    Maybe mention that it does not influence rankings. It only gives search engines hints about how often your page is updated.
  20. Richard Haeser uploaded patch set 18 04/15/19, 19:13

  21. Richard Haeser voted on patch set 18 V +1 CR +1 04/15/19, 19:15

  22. TYPO3com voted on patch set 18 V +1 04/15/19, 19:26 Completed build in 13m 15s on Mon, 15 Apr, 09:26 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33283

  23. Jörg Bösche voted on patch set 18 V +1 CR +1 04/15/19, 19:46

  24. Richard Haeser voted on patch set 18 V +2 CR +2 04/15/19, 19:48

  25. Richard Haeser merged patch set 19 04/15/19, 19:48