Review main Abandoned

59837[TASK] Use TYPO3.lang and appropriate XLF files for plugin localization

Jo Hasenau CR 0 V 0 Hard +23 −467 updated 11/04/21, 16:53

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 70

Show 50 more files

Review log 1823

  1. Jo Hasenau uploaded patch set 1 03/04/19, 10:46

  2. TYPO3com voted on patch set 1 V -1 03/04/19, 10:46 Completed build in 10s on Mon, 4 Mar, 11:46 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32499

  3. Jo Hasenau uploaded patch set 2 03/04/19, 10:54

  4. Jo Hasenau updated the commit message in patch set 3 03/04/19, 11:03

  5. TYPO3com voted on patch set 2 V -1 03/04/19, 11:11 Completed build in 16m 50s on Mon, 4 Mar, 12:11 PM Test Summary: 1 of 47034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32500

  6. TYPO3com voted on patch set 3 V -1 03/04/19, 11:14 Completed build in 09m 59s on Mon, 4 Mar, 12:13 PM Test Summary: 1 of 47034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32502

  7. Jo Hasenau uploaded patch set 4 03/04/19, 11:30

  8. TYPO3com voted on patch set 4 V +1 03/04/19, 11:43 Completed build in 12m 58s on Mon, 4 Mar, 12:43 PM Test Summary: 46641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32504

  9. TYPO3com commented on patch set 4 10/10/19, 08:31 Completed build in 14m 05s on Thu, 10 Oct, 08:31 AM Test Summary: 47719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37201

  10. Jörg Bösche voted on patch set 4 CR +1 10/11/19, 08:09

  11. Felix P. voted on patch set 4 CR +1 10/11/19, 09:25

  12. Steffen Frese voted on patch set 4 CR +1 01/16/20, 12:27

  13. Frank Nägler voted on patch set 4 CR +1 01/17/20, 14:35

  14. Frank Nägler wrote 01/17/20, 14:35

    Topic set to CKEditor
  15. Georg Ringer commented on patch set 4 CR -1 01/17/20, 19:19

    why do we need to remove the translations of the plugins, especially if those are 3rd party and what if those provide translations we don't have yet?
  16. Josef Glatz commented on patch set 4 CR -1 04/05/20, 21:16

    > Patch Set 4: Code-Review-1 > > why do we need to remove the translations of the plugins, especially if those are 3rd party and what if those provide translations we don't have yet? In general, it can be a benefit. But as you say, directly commited plugins (which are in the folder typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Plugins/) needs to be always modified if you we don't want translations in the this folder. This would be ok, since the plugins are processed primarily. You mentioned 3rd-party extensions in the TYPO3 core. Actually only the wordcount CKEditor plugin was added via npm/yarn and are moved into typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins. (folder:wordcount). --- @Jo: do you have any workaround actually on how to solve this? I will also investigate if it makes sense to pass TYPO3.lang.
  17. Jo Hasenau commented on patch set 4 04/06/20, 11:26

    > Patch Set 4: Code-Review-1 > > > Patch Set 4: Code-Review-1 > > > > why do we need to remove the translations of the plugins, especially if those are 3rd party and what if those provide translations we don't have yet? > > In general, it can be a benefit. > > But as you say, directly commited plugins (which are in the folder typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Plugins/) needs to be always modified if you we don't want translations in the this folder. This would be ok, since the plugins are processed primarily. > > You mentioned 3rd-party extensions in the TYPO3 core. Actually only the wordcount CKEditor plugin was added via npm/yarn and are moved into typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/plugins. (folder:wordcount). > > --- > > @Jo: do you have any workaround actually on how to solve this? I will also investigate if it makes sense to pass TYPO3.lang. This is the original task as it was taken from the TYPO3 jira to create the forge ticket. So basically this is not my idea, but currently built as requested: Our custom plugins currently rely on shipped translations with the code. This has the major drawback that we cannot use the TYPO3 translation server and we are not able to provide/update translations without a TYPO3 release. We need to utilize the TYPO3 translation api here. Please see for example: QuickTable: https://github.com/TYPO3/TYPO3.CMS/tree/master/typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Plugins/quicktable/lang SoftHyphens https://review.typo3.org/#/c/57344/ Since it already got a +1 from Frank, maybe he can elaborate on the original idea?
  18. Benni Mack updated the commit message in patch set 5 05/25/20, 18:46

  19. Benni Mack commented on patch set 5 CR -1 11/18/20, 17:01

    seems like this review is stale, and the -1s are still not resolved (even after my rebase 6 months ago), as nothing is moving forward. Anyone up for picking this review up?
  20. Jo Hasenau commented on patch set 5 11/18/20, 18:31

    > Patch Set 5: Code-Review-1 > > seems like this review is stale, and the -1s are still not resolved (even after my rebase 6 months ago), as nothing is moving forward. Anyone up for picking this review up? Well - actually this was my task which was blocked by two -1, which were actually not based on the code itself but on questions, why this should be done at all. So I don't get what should have been "resolved" in this case, because as mentioned in the comments, this was not my idea but just a job I got assigned by request. Since nobody seemed to care about it, I just stopped working on it and switched to other more important tasks instead.
  21. Josef Glatz commented on patch set 5 12/01/20, 05:22

    In general it would be great if those things can be translated. But how do we handle CKE updates then? Do it need some more magic post scripts when somebody updates CKE in core?
  22. Josef Glatz voted on patch set 5 CR -1 12/21/20, 12:57

  23. Oliver Hader abandoned the change 11/04/21, 16:53

    > Patch Set 5: > Since nobody seemed to care about it, I just stopped working on it and switched to other more important tasks instead. Alright, closing this one.