Review main Merged

59839[BUGFIX] Use finder instance correctly

Jan Delius CR +2 V +2 Normal +166 −3 updated 04/14/19, 15:28

Commit message

Within SiteTcaConfiguration, the $finder is now reused as much as
possible. A new clean instance is used for the individual actions.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Jörg Bösche +1
  • Verified V +2 Done
    • Susi Moog +2
    • Rico Drexler +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2840

Show 1115 earlier messages
  1. Jan Delius uploaded patch set 1 03/04/19, 12:57

  2. Jan Delius uploaded patch set 2 03/04/19, 13:02

  3. Rico Drexler voted on patch set 2 V +1 CR +1 03/04/19, 13:09

  4. TYPO3com voted on patch set 1 V -1 03/04/19, 13:11 Completed build in 13m 50s on Mon, 4 Mar, 02:11 PM Test Summary: 1 of 47034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32506

  5. TYPO3com voted on patch set 2 V -1 03/04/19, 13:15 Completed build in 13m 04s on Mon, 4 Mar, 02:15 PM Test Summary: 1 of 47034 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32507

  6. Jan Delius uploaded patch set 3 03/04/19, 13:22

  7. TYPO3com voted on patch set 3 V +1 03/04/19, 13:36 Completed build in 14m 02s on Mon, 4 Mar, 02:36 PM Test Summary: 46641 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32508

  8. Rico Drexler commented on patch set 3 V +1 CR +1 03/04/19, 15:15

    > Patch Set 2: Verified+1 Code-Review+1
  9. Oliver Klee commented on patch set 3 03/04/19, 15:47

    Can we have tests for this?
  10. Alexander Schnitzler commented on patch set 3 03/04/19, 17:31

    correctly
  11. Jan Delius updated the commit message in patch set 4 03/06/19, 08:04

  12. Jan Delius commented on patch set 4 03/06/19, 08:05

    > Patch Set 3: > > Can we have tests for this? I'm not sure how exactly to build tests for this part. Maybe someone else can help out here?
  13. TYPO3com voted on patch set 4 V +1 03/06/19, 08:14 Completed build in 10m 19s on Wed, 6 Mar, 09:14 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32546

  14. Susi Moog voted on patch set 4 CR +1 03/11/19, 21:05

  15. Jan Delius uploaded patch set 5 03/12/19, 13:45

  1. TYPO3com voted on patch set 5 V -1 03/12/19, 13:46 Completed build in 13s on Tue, 12 Mar, 02:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32674

  2. Jan Delius uploaded patch set 6 03/12/19, 13:49

  3. TYPO3com voted on patch set 6 V -1 03/12/19, 14:02 Completed build in 12m 53s on Tue, 12 Mar, 03:02 PM Test Summary: 47209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32675

  4. Jan Delius uploaded patch set 7 03/12/19, 14:40

  5. TYPO3com voted on patch set 7 V +1 03/12/19, 14:53 Completed build in 12m 54s on Tue, 12 Mar, 03:53 PM Test Summary: 47209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32676

  6. Jan Delius commented on patch set 7 03/12/19, 14:55

    I did some research in the core and wrote tests for this function. I hope that they are correctly implemented. If anything is wrong I am happy to be taught the right way.
  7. Jan Delius commented on patch set 7 03/12/19, 14:57

    > Patch Set 3: > > Can we have tests for this? Done since Patch Set 4

    Reply

    Done
  8. Oliver Klee commented on patch set 8 03/12/19, 14:57

    Published edit on patch set 7.
  9. TYPO3com voted on patch set 8 V -1 03/12/19, 14:57 Completed build in 10s on Tue, 12 Mar, 03:57 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32677

  10. Jan Delius uploaded patch set 9 03/12/19, 14:59

  11. Oliver Klee commented on patch set 8 03/12/19, 15:00

    I don't quite understand the build failure … can somebody make sense of this?
  12. Susi Moog commented on patch set 9 03/12/19, 16:33

    > Patch Set 8: > > I don't quite understand the build failure … can somebody make sense of this? look left, CGL failed. look into logs, there's: 12-Mar-2019 15:57:58 Loaded config default from "Build/.php_cs". 12-Mar-2019 15:57:58 F..... 12-Mar-2019 15:57:58 Legend: ?-unknown, I-invalid file syntax, file ignored, S-Skipped, .-no changes, F-fixed, E-error 12-Mar-2019 15:57:58 1) Build/../typo3/sysext/backend/Tests/Functional/Configuration/SiteConfiguration/SiteConfigurationOverridesTest.php (no_unused_imports) 12-Mar-2019 15:57:58 ---------- begin diff ---------- 12-Mar-2019 15:57:58 --- Original 12-Mar-2019 15:57:58 +++ New 12-Mar-2019 15:57:58 @@ -17,7 +17,6 @@ 12-Mar-2019 15:57:58 */ 12-Mar-2019 15:57:58 12-Mar-2019 15:57:58 use TYPO3\CMS\Backend\Configuration\SiteTcaConfiguration; 12-Mar-2019 15:57:58 -use TYPO3\CMS\Core\Utility\GeneralUtility; 12-Mar-2019 15:57:58 use TYPO3\TestingFramework\Core\Functional\FunctionalTestCase; 12-Mar-2019 15:57:58 12-Mar-2019 15:57:58 /** 12-Mar-2019 15:57:58 12-Mar-2019 15:57:58 ----------- end diff -----------
  13. Oliver Klee commented on patch set 9 03/12/19, 16:49

    > look left, CGL failed. look into logs, there's: ah, thanks!
  14. TYPO3com voted on patch set 9 V +1 03/12/19, 20:02 Completed build in 14m 27s on Tue, 12 Mar, 09:02 PM Test Summary: 47209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32680

  15. Jan Delius uploaded patch set 10 03/13/19, 07:02

  16. Jan Delius uploaded patch set 11 03/13/19, 07:07

  17. Jan Delius commented on patch set 11 03/13/19, 07:08

    After I accidentally overwrote patch set 8, the changes have now been taken over again.

    SiteConfigurationOverridesTest.php:49 Unresolved

    Why should you only initialize the object and not get the configuration? Otherwise you have to do this in each function individually although nothing changes.
  18. TYPO3com voted on patch set 10 V +1 03/13/19, 07:18 Completed build in 15m 05s on Wed, 13 Mar, 08:18 AM Test Summary: 47209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32687

  19. TYPO3com voted on patch set 11 V +1 03/13/19, 07:21 Completed build in 14m 19s on Wed, 13 Mar, 08:21 AM Test Summary: 47209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32688

  20. Oliver Klee commented on patch set 12 03/13/19, 11:48

    Published edit on patch set 11.
  21. TYPO3com voted on patch set 12 V +1 03/13/19, 11:59 Completed build in 10m 20s on Wed, 13 Mar, 12:59 PM Test Summary: 47209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32693

  22. Rico Drexler voted on patch set 12 V +1 04/01/19, 06:56

  23. Jörg Bösche voted on patch set 12 CR +1 04/08/19, 13:27

  24. Susi Moog voted on patch set 12 V +2 CR +2 04/14/19, 15:28

  25. Susi Moog merged patch set 13 04/14/19, 15:28