Review 9.5 Merged

59842[BUGFIX] Force closing tag in PageViewHelper

Benni Mack CR +2 V +2 Easy +1 −0 updated 03/04/19, 15:18

Commit message

Unlike all the other link viewhelpers (based on tagbuilder),
the PageViewHelper does not force the closing tag which
results in an invalid tag when there is no content available.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 03/04/19, 13:54

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/04/19, 14:11 Completed build in 16m 17s on Mon, 4 Mar, 03:11 PM Test Summary: 49333 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-317

  3. Benni Mack voted on patch set 1 V +2 CR +2 03/04/19, 15:18

  4. Benni Mack merged patch set 2 03/04/19, 15:18