Review TYPO3_8-7 Merged

59843[BUGFIX] Force closing tag in PageViewHelper

Benni Mack CR +2 V +2 Easy +1 −0 updated 03/04/19, 18:24

Commit message

Unlike all the other link viewhelpers (based on tagbuilder),
the PageViewHelper does not force the closing tag which
results in an invalid tag when there is no content available.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Benni Mack commented on patch set 1 03/04/19, 15:17

    Cherry Picked from branch 9.5.
  2. TYPO3com voted on patch set 1 V +1 03/04/19, 15:44 Completed build in 27m 25s on Mon, 4 Mar, 04:44 PM Test Summary: 79524 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3431

  3. Oliver Klee voted on patch set 1 CR +1 03/04/19, 15:46

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/04/19, 18:24

  5. Benni Mack merged patch set 2 03/04/19, 18:24