Review main Merged

59851[BUGFIX] Add requireJs for Inline JavaScript in file replace view

Frank Nägler CR +2 V +2 Easy +3 −1 updated 03/08/19, 21:54

Commit message

Review

  • Code review CR +2 Done
    • Wouter Wolters +2
    • Susi Moog +1
  • Verified V +2 Done
    • Wouter Wolters +2
    • Riccardo De Contardi +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Frank Nägler uploaded patch set 1 03/04/19, 20:46

  2. Frank Nägler commented on patch set 2 03/04/19, 20:52

    Published edit on patch set 1.
  3. Susi Moog voted on patch set 2 CR +1 03/04/19, 20:52

  4. Riccardo De Contardi commented on patch set 2 V +1 03/04/19, 21:01

    tested on Master, replacing files with the same name seems to work fine :)
  5. Susi Moog voted on patch set 2 V +1 03/04/19, 21:01

  6. TYPO3com voted on patch set 1 V +1 03/04/19, 21:02 Completed build in 15m 57s on Mon, 4 Mar, 10:02 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32520

  7. TYPO3com voted on patch set 2 V +1 03/04/19, 21:07 Completed build in 13m 29s on Mon, 4 Mar, 10:07 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32522

  8. Wouter Wolters voted on patch set 2 V +2 CR +2 03/08/19, 21:54

  9. Wouter Wolters merged patch set 3 03/08/19, 21:54