Review main Abandoned

59874[TASK] Use proper class name for signal

Florian Wessels CR 0 V 0 Easy +4 −4 updated 03/06/19, 08:04

Commit message

Use proper class name for tablesDefinitionIsBeingBuild signal

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 34

  1. Florian Wessels uploaded patch set 1 03/05/19, 16:25

  2. TYPO3com voted on patch set 1 V +1 03/05/19, 16:35 Completed build in 10m 06s on Tue, 5 Mar, 05:35 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32540

  3. Mathias Brodala commented on patch set 1 CR -1 03/05/19, 16:41

    SqlReader.php:152 Unresolved

    Did you read the comment above about backwards compat?
  4. Mathias Brodala abandoned the change 03/06/19, 08:04

    The current code works as intended.