59875[BUGFIX] Access and update attribute `data-action` explicitly in Core Updater
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 79
-
Andreas Kienast uploaded patch set 1 03/05/19, 20:09
-
TYPO3com voted on patch set 1 V +1 03/05/19, 20:20 Completed build in 11m 06s on Tue, 5 Mar, 09:20 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32541
-
Susi Moog voted on patch set 1 V +1 CR +1 03/05/19, 21:28
-
Andreas Kienast uploaded patch set 2 03/06/19, 08:14
-
Susi Moog voted on patch set 2 V +1 CR +1 03/06/19, 08:19
-
TYPO3com voted on patch set 2 V +1 03/06/19, 08:28 Completed build in 14m 26s on Wed, 6 Mar, 09:28 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32547
-
Benni Mack voted on patch set 2 V +2 CR +2 03/06/19, 09:05
-
Benni Mack merged patch set 3 03/06/19, 09:05
-
Oliver Hader commented on patch set 3 03/06/19, 20:08
Side-note on reference in JavaScript...CoreUpdate.js:253Unresolvedthis.buttonTemplate.clone() - otherwise the data attribute is changed in the template as well... not sure whether that's used again, but if it is, would lead to side-effects