Review main Merged

59875[BUGFIX] Access and update attribute `data-action` explicitly in Core Updater

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 03/06/19, 20:08

Commit message

This patch updates the data attribute `action` via overriding the HTML
attribute. Previously, jQuery's `.data()` was used which broke the
functionality as the DOM gets re-rendered and jQuery lost the overriden
value in its data object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 03/05/19, 20:09

  2. TYPO3com voted on patch set 1 V +1 03/05/19, 20:20 Completed build in 11m 06s on Tue, 5 Mar, 09:20 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32541

  3. Susi Moog voted on patch set 1 V +1 CR +1 03/05/19, 21:28

  4. Andreas Kienast uploaded patch set 2 03/06/19, 08:14

  5. Susi Moog voted on patch set 2 V +1 CR +1 03/06/19, 08:19

  6. TYPO3com voted on patch set 2 V +1 03/06/19, 08:28 Completed build in 14m 26s on Wed, 6 Mar, 09:28 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32547

  7. Benni Mack voted on patch set 2 V +2 CR +2 03/06/19, 09:05

  8. Benni Mack merged patch set 3 03/06/19, 09:05

  9. Oliver Hader commented on patch set 3 03/06/19, 20:08

    Side-note on reference in JavaScript...

    CoreUpdate.js:253 Unresolved

    this.buttonTemplate.clone() - otherwise the data attribute is changed in the template as well... not sure whether that's used again, but if it is, would lead to side-effects