Review 9.5 Merged

59877[BUGFIX] Access and update attribute `data-action` explicitly in Core Updater

Benni Mack CR +2 V +2 Easy +4 −2 updated 03/06/19, 14:09

Commit message

This patch updates the data attribute `action` via overriding the HTML
attribute. Previously, jQuery's `.data()` was used which broke the
functionality as the DOM gets re-rendered and jQuery lost the overriden
value in its data object.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Benni Mack commented on patch set 1 03/06/19, 09:05

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 03/06/19, 09:19 Completed build in 13m 16s on Wed, 6 Mar, 10:19 AM Test Summary: 3 of 50011 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-330

  3. TYPO3com voted on patch set 1 V +1 03/06/19, 09:25 Completed build in 32m 40s on Wed, 6 Mar, 10:25 AM Test Summary: 49540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-330

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/06/19, 14:09

  5. Benni Mack merged patch set 2 03/06/19, 14:09