Review main Merged

59882[BUGFIX] Use renamed folder object in postRename signal

Susi Moog CR +2 V +2 Easy +1 −1 updated 03/17/19, 14:31

Commit message

The documentation states that the `emitPostFolderRename` signal
receives a reference to the renamed folder object. (see
https://docs.typo3.org/typo3cms/CoreApiReference/ApiOverview/Fal/Architecture/Signals.html)

The input of the signal has been adjusted to use the returned renamed
reference instead of the original folder to be renamed.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1114

  1. Susi Moog uploaded patch set 1 03/06/19, 12:05

  2. TYPO3com voted on patch set 1 V -1 03/06/19, 12:16 Completed build in 10m 54s on Wed, 6 Mar, 01:16 PM Test Summary: 2 of 47205 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32555

  3. TYPO3com voted on patch set 1 V +1 03/06/19, 12:46 Completed build in 52m 24s on Wed, 6 Mar, 01:46 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32555

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 03/06/19, 18:53

  5. Benni Mack commented on patch set 1 03/07/19, 13:40

    this breaks existing slots IMHO, so either add another argument or master-only please.
  6. Susi Moog commented on patch set 1 03/07/19, 14:22

    @Benni: hmm, then I'd say master only. Basically if that breaks slots then they were relying on a broken argument to begin with, but I'd be fine with only master. (and maybe someone should adjust older docs then)
  7. Benni Mack updated the commit message in patch set 2 03/07/19, 17:24

  8. Benni Mack voted on patch set 2 CR +1 03/07/19, 17:24

  9. TYPO3com voted on patch set 2 V +1 03/07/19, 17:42 Completed build in 18m 08s on Thu, 7 Mar, 06:42 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32581

  10. Benni Mack voted on patch set 2 V +1 03/07/19, 18:04

  11. Frank Nägler commented on patch set 2 03/08/19, 21:46

    I think this is a breaking change and a change of behavior. This patch IMHO needs an rst-file.
  12. Susi Moog commented on patch set 2 03/10/19, 17:47

    > Patch Set 2: > > I think this is a breaking change and a change of behavior. > This patch IMHO needs an rst-file. I'm unsure... it's documented like it is now after the patch, so the rst file would just say it now works as advertised (which is somehow the description of any bugfix) - I can add the rst but I don't know what exactly that means. I mean, if we consider this breaking then that basically means that we now want compat to the way it was before --> then let's just change the docs to reflect the actual code and abandon the change.
  13. Benjamin Franzke commented on patch set 2 V +2 CR +2 03/17/19, 14:31

    I think this is a classical bugfix, as the previous buggy state was not really useful: A reference to a folder that has just been renamed couldn't (really) be used anyway. Therefore I agree that a .rst is not required. Well, is say "not really" as there is one exception: One could have parsed the new name into the old folder identigier: dirname($folder->getIdentifier()) . '/' . $name It's an ugly hack but would have worked. The good thing is: That hack will keep on working even with this bugfix applied. Therefore I think this is safe to merge.
  14. Benjamin Franzke merged patch set 3 03/17/19, 14:31