Review main Merged

59883[BUGFIX] Remove possibility to exclude width/height in sys_file_metadata

Susi Moog CR +2 V +2 Easy +0 −2 updated 03/08/19, 21:57

Commit message

Width and height are readonly fields updated by system image service API.
To ensure the API (for example the crop wizard) works flawlessly for
editors out of the box, width and height are no longer exclude fields.

Bugfix is for master only, as the workaround for earlier versions is
as simple as putting this in TCA overrides:

unset(
    $GLOBALS['TCA']['sys_file_metadata']['columns']['width']['exclude'],
    $GLOBALS['TCA']['sys_file_metadata']['columns']['height']['exclude']
);

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Anja Leichsenring +1
    • Riccardo De Contardi +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 911

  1. Susi Moog uploaded patch set 1 03/06/19, 12:44

  2. TYPO3com voted on patch set 1 V +1 03/06/19, 12:54 Completed build in 09m 52s on Wed, 6 Mar, 01:54 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32556

  3. Mathias Brodala updated the commit message in patch set 2 03/06/19, 13:20

  4. Mathias Brodala voted on patch set 2 CR +1 03/06/19, 13:20

  5. TYPO3com voted on patch set 2 V +1 03/06/19, 13:30 Completed build in 10m 21s on Wed, 6 Mar, 02:30 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32557

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 03/06/19, 18:55

  7. Riccardo De Contardi voted on patch set 2 V +1 03/07/19, 21:25

  8. Frank Nägler voted on patch set 2 V +2 CR +2 03/08/19, 21:40

  9. Frank Nägler merged patch set 3 03/08/19, 21:40

  10. Stephan Großberndt commented on patch set 3 03/08/19, 21:51

    Hm, I don't get why that patch is not backported. Of course I can change all kinds of stuff in my local installations by setting sth in TCA. If it's broken without access (and exclude=1 defaults to no access, right?), let's fix it - or is the "system image API" some new v10 master only stuff?
  11. Frank Nägler commented on patch set 3 03/08/19, 21:57

    I guess that a backport would be a change of behavior, which should be prevented in stable branches. But maybe Susi has other reasons.