Review main Merged

59887[BUGFIX] Ensure result is string in __toString of CropVariantCollection

Susi Moog CR +2 V +2 Easy +10 −1 updated 03/16/19, 11:24

Commit message

CropVariantCollection returns output from json_encode in its __toString
method. Json_encode may return false if it fails to properly encode the
given data (mostly when non-UTF8 data is given). To ensure that no
exception is thrown to the user in that case, the __toString method
has been adjusted to return the same result as in the empty variants case.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Stephan Großberndt +1
    • Wouter Wolters +1
    • Anja Leichsenring +1
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Anja Leichsenring +1
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1011

  1. Susi Moog uploaded patch set 1 03/06/19, 18:04

  2. TYPO3com voted on patch set 1 V +1 03/06/19, 18:19 Completed build in 14m 32s on Wed, 6 Mar, 07:19 PM Test Summary: 46816 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32563

  3. Anja Leichsenring voted on patch set 1 V +1 CR +1 03/06/19, 18:57

  4. Wouter Wolters voted on patch set 1 CR +1 03/08/19, 22:23

  5. Stephan Großberndt commented on patch set 1 03/08/19, 23:05

    This means if there is an error when returning a CropVariantCollection due to problems with characters in it now silently it looks like there is no CropVariantCollection at all?
  6. Oliver Klee voted on patch set 1 CR +1 03/08/19, 23:16

  7. Tymoteusz Motylewski voted on patch set 1 V +1 CR +1 03/09/19, 11:58

  8. Susi Moog commented on patch set 1 03/15/19, 12:28

    > Patch Set 1: > > This means if there is an error when returning a CropVariantCollection due to problems with characters in it now silently it looks like there is no CropVariantCollection at all? yes as the editor most likely cannot react to that in any way.
  9. Stephan Großberndt voted on patch set 1 CR +1 03/15/19, 16:22

  10. Daniel Goerz voted on patch set 1 V +2 CR +2 03/16/19, 11:24

  11. Daniel Goerz merged patch set 2 03/16/19, 11:24