Review main Abandoned

59890[BUGFIX] Read checkbox value from object only in object access mode

Julian Wundrak CR 0 V 0 Easy +2 −2 updated 11/10/21, 11:50

Commit message

This patch changes the reading of value in f:form.checkbox
and f:form.radio so the ViewHelper will not attempt to read
the value from a form object if no form object exists.

Checking $this->isObjectAccessorMode() prevents the issue.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1722

  1. Julian Wundrak uploaded patch set 1 03/06/19, 20:24

  2. TYPO3com voted on patch set 1 V +1 03/06/19, 20:40 Completed build in 16m 09s on Wed, 6 Mar, 09:40 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32568

  3. Claus Due updated the commit message in patch set 2 03/08/19, 12:58

  4. Claus Due commented on patch set 2 03/08/19, 13:03

    Needs forge issue and release annotations. We may want to only include this in v10 since it potentially breaks existing implementations that expect properties to be read from a (manually assigned) form object regardless of object access mode. I've adapted the commit message to make the description more generic since this doesn't only apply to __call methods but indeed any method of reading a property from a form object when form is not explicitly in object access mode.
  5. TYPO3com voted on patch set 2 V +1 03/08/19, 13:15 Completed build in 16m 41s on Fri, 8 Mar, 02:15 PM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32611

  6. Julian Wundrak updated the commit message in patch set 3 03/28/19, 19:40

  7. Julian Wundrak updated the commit message in patch set 4 03/28/19, 19:41

  8. TYPO3com voted on patch set 3 V +1 03/28/19, 19:58 Completed build in 17m 36s on Thu, 28 Mar, 08:58 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32998

  9. TYPO3com voted on patch set 4 V +1 03/28/19, 19:58 Completed build in 16m 22s on Thu, 28 Mar, 08:58 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32999

  10. Julian Geils voted on patch set 4 CR +1 07/08/19, 12:35

  11. Oliver Klee commented on patch set 4 07/08/19, 13:17

    Can we have regression tests for this?
  12. Steffen Frese voted on patch set 4 CR +1 01/16/20, 12:21

  13. Sascha Rademacher voted on patch set 4 CR +1 01/17/20, 10:00

  14. Henning Liebe voted on patch set 4 CR +1 01/17/20, 10:32

  15. Felix P. voted on patch set 4 CR +1 01/17/20, 10:46

  16. Alexander Schnitzler wrote 02/28/20, 19:15

    Topic set to fluid
  17. Alexander Schnitzler commented on patch set 4 CR -2 02/28/20, 19:17

    As Claus mentioned a year ago, this patch is possibly breaking. Since we are now in stabilization phase for 10 LTS, I'd postpone this to version 11. Until then, the patch is blocked.
  18. Benni Mack updated the commit message in patch set 5 05/25/20, 18:44

  19. TYPO3com voted on patch set 5 V +1 05/25/20, 19:46 Completed build in 56m 36s on Mon, 25 May, 07:46 PM Test Summary: 73808 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3535

  20. Alexander Schnitzler commented on patch set 5 CR 0 10/09/20, 08:41

    Removing -2 since we are now in 11.0 development phase.
  21. Daniel Goerz commented on patch set 5 10/09/20, 08:43

    How do I reproduce the bug?
  22. Benni Mack abandoned the change 11/10/21, 11:50

    I will abandon this change now, as there has been no progress, and lack of feedback from the mergers in the past 12 months. can be restored once somebody is willing to invest time in it.