59891[BUGFIX] URL without base runs into a redirect loop
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1519
-
Julian Wundrak uploaded patch set 1 03/06/19, 20:32
-
TYPO3com voted on patch set 1 V +1 03/06/19, 20:47 Completed build in 15m 13s on Wed, 6 Mar, 09:47 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32569
-
Guido Schmechel commented on patch set 1 03/08/19, 05:25
Unresolved
Can you please add Releases and Resolves line, see https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/Appendix/CommitMessage.html#commitmessage -
Guido Schmechel commented on patch set 1 03/08/19, 05:42
And please have a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59815 Seems to be the same topic ;-) -
Benni Mack commented on patch set 1 CR -1 03/14/19, 07:10
Ticket number and affected branches are missing. -
Julian Wundrak updated the commit message in patch set 2 03/28/19, 19:59
-
Julian Wundrak updated the commit message in patch set 3 03/28/19, 20:13
-
TYPO3com voted on patch set 2 V +1 03/28/19, 20:15 Completed build in 16m 33s on Thu, 28 Mar, 09:15 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33000
-
TYPO3com voted on patch set 3 V +1 03/28/19, 20:35 Completed build in 16m 44s on Thu, 28 Mar, 09:35 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33003
-
André Buchmann commented on patch set 3 04/05/19, 10:44
I've tested your example successful with the patch from https://review.typo3.org/c/Packages/TYPO3.CMS/+/59815 As the other patch catches more cases, I would prefer to merge 59815. -
Jörg Bösche voted on patch set 3 CR +1 04/08/19, 11:03
-
Julian Geils voted on patch set 3 V +1 CR +1 04/10/19, 13:58
-
Steffen Frese commented on patch set 3 V +1 CR +1 04/11/19, 09:56
verified on latest master -
Benni Mack commented on patch set 3 CR -1 04/15/19, 03:46
After lookin more close I suggest to remove the second redirect "Request was "/fr-FR" but the site is actually called "/fr-FR/" completely. This actually solves even more issues. -
Benni Mack uploaded patch set 4 04/18/19, 10:42
-
Benni Mack voted on patch set 4 V +1 CR +1 04/18/19, 10:49
-
TYPO3com voted on patch set 4 V +1 04/18/19, 10:56 Completed build in 13m 36s on Thu, 18 Apr, 12:56 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33338
-
Georg Ringer voted on patch set 4 V +2 CR +2 04/18/19, 11:25
-
Georg Ringer merged patch set 5 04/18/19, 11:25
Unresolved