Review main Merged

59891[BUGFIX] URL without base runs into a redirect loop

Julian Wundrak CR +2 V +2 Easy +0 −12 updated 04/18/19, 11:25

Commit message

Calling something like bla.example.com/?id=34&type=2
runs in a endless loop.

The change removes the restrictive redirect.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1519

  1. Julian Wundrak uploaded patch set 1 03/06/19, 20:32

  2. TYPO3com voted on patch set 1 V +1 03/06/19, 20:47 Completed build in 15m 13s on Wed, 6 Mar, 09:47 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32569

  3. Guido Schmechel commented on patch set 1 03/08/19, 05:25

    Unresolved

    Bugfix
  4. Guido Schmechel commented on patch set 1 03/08/19, 05:42

    And please have a look at https://review.typo3.org/c/Packages/TYPO3.CMS/+/59815 Seems to be the same topic ;-)
  5. Benni Mack commented on patch set 1 CR -1 03/14/19, 07:10

    Ticket number and affected branches are missing.
  6. Julian Wundrak updated the commit message in patch set 2 03/28/19, 19:59

  7. Julian Wundrak updated the commit message in patch set 3 03/28/19, 20:13

  8. TYPO3com voted on patch set 2 V +1 03/28/19, 20:15 Completed build in 16m 33s on Thu, 28 Mar, 09:15 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33000

  9. TYPO3com voted on patch set 3 V +1 03/28/19, 20:35 Completed build in 16m 44s on Thu, 28 Mar, 09:35 PM Test Summary: 47257 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33003

  10. André Buchmann commented on patch set 3 04/05/19, 10:44

    I've tested your example successful with the patch from https://review.typo3.org/c/Packages/TYPO3.CMS/+/59815 As the other patch catches more cases, I would prefer to merge 59815.
  11. Jörg Bösche voted on patch set 3 CR +1 04/08/19, 11:03

  12. Julian Geils voted on patch set 3 V +1 CR +1 04/10/19, 13:58

  13. Steffen Frese commented on patch set 3 V +1 CR +1 04/11/19, 09:56

    verified on latest master
  14. Benni Mack commented on patch set 3 CR -1 04/15/19, 03:46

    After lookin more close I suggest to remove the second redirect "Request was "/fr-FR" but the site is actually called "/fr-FR/" completely. This actually solves even more issues.
  15. Benni Mack uploaded patch set 4 04/18/19, 10:42

  16. Benni Mack voted on patch set 4 V +1 CR +1 04/18/19, 10:49

  17. TYPO3com voted on patch set 4 V +1 04/18/19, 10:56 Completed build in 13m 36s on Thu, 18 Apr, 12:56 PM Test Summary: 47469 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33338

  18. Georg Ringer voted on patch set 4 V +2 CR +2 04/18/19, 11:25

  19. Georg Ringer merged patch set 5 04/18/19, 11:25