Review main Merged

59892[BUGFIX] Fix @var comment in AbstractFileCollection

Susi Moog CR +2 V +2 Easy +1 −1 updated 03/07/19, 11:45

Commit message

A collection can contain either File or FileReferences. The typehint
only referenced Files confusing developers. The typehint has been
fixed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Susi Moog uploaded patch set 1 03/07/19, 08:45

  2. TYPO3com voted on patch set 1 V +1 03/07/19, 08:56 Completed build in 10m 22s on Thu, 7 Mar, 09:56 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32570

  3. Oliver Klee voted on patch set 1 CR +1 03/07/19, 09:48

  4. Benni Mack commented on patch set 1 V +2 CR +2 03/07/19, 11:45

    non-functional change. will merge directly
  5. Benni Mack merged patch set 2 03/07/19, 11:45