Review main Merged

59893[BUGFIX] Log invalid hash generation in FAL Indexer

Susi Moog CR +2 V +2 Normal +75 −30 updated 11/09/19, 15:51

Commit message

The FAL Indexer uses the driver to get a hash for a file. In certain
circumstances (and with 3rd party drivers) the hash generated might be
null or invalid. In that case the ResourceStorage now throws an
exception to alert the developer to the wrong return value. At the same
time the Indexer catches and logs the exception to not interrupt the
whole indexing flow because of it.

For more information, please take a look at the ticket.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Georg Ringer +1
    • Guido Schmechel +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1622

  1. Susi Moog uploaded patch set 1 03/07/19, 09:41

  2. TYPO3com voted on patch set 1 V -1 03/07/19, 09:41 Completed build in 11s on Thu, 7 Mar, 10:41 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32571

  3. Susi Moog uploaded patch set 2 03/07/19, 09:43

  4. Oliver Klee commented on patch set 3 03/07/19, 09:48

    Published edit on patch set 2.
  5. TYPO3com voted on patch set 2 V +1 03/07/19, 10:00 Completed build in 16m 37s on Thu, 7 Mar, 11:00 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32572

  6. TYPO3com voted on patch set 3 V +1 03/07/19, 10:04 Completed build in 15m 47s on Thu, 7 Mar, 11:04 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32573

  7. Benni Mack commented on patch set 3 03/07/19, 12:01

    ResourceStorage.php:1251

    this is nit picking, but now having exceptions thrown in FE/BE due to "accidentally" indexing a file, might be an issue when upgrading from 9.5.5. to 9.5.6 in the future?
  8. Susi Moog commented on patch set 3 03/07/19, 15:03

    ResourceStorage.php:1251 Reply Unresolved

    this breaks when: - Hashing mechanism is broken and returns invalid hash - File is not yet indexed AND in Frontend: - getData with `file:sha1` from ContentObjectRenderer is used (happens ONLY with this key) AND in Backend: - On import of data structures with Import/Export if the storage has a file with the same identifier as the uploaded which has not been indexed - On export of non-indexed files ... and at least in backend case the exception is actually imho an improvement over silently failing - I'm catching in the indexer only because I want it to continue indexing.
  9. Susi Moog commented on patch set 3 08/03/19, 09:31

    @Benni alternative: master only?
  10. Susi Moog rebased onto patch set 4 08/03/19, 09:31

  11. TYPO3com voted on patch set 4 V -1 08/03/19, 09:41 Completed build in 10m 08s on Sat, 3 Aug, 09:41 AM Test Summary: 16 of 47531 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35539

  12. TYPO3com voted on patch set 4 V +1 08/03/19, 09:51 Completed build in 30m 02s on Sat, 3 Aug, 09:51 AM Test Summary: 47172 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35539

  13. Susi Moog updated the commit message in patch set 5 10/25/19, 21:41

  14. TYPO3com voted on patch set 5 V +1 10/25/19, 21:53 Completed build in 12m 09s on Fri, 25 Oct, 09:53 PM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37752

  15. Benni Mack voted on patch set 5 CR +1 10/29/19, 09:36

  16. Georg Ringer voted on patch set 5 CR +1 10/31/19, 06:37

  17. Frank Nägler voted on patch set 5 CR +1 11/08/19, 15:06

  18. Guido Schmechel voted on patch set 5 CR +1 11/09/19, 10:20

  19. Daniel Goerz voted on patch set 5 CR +1 11/09/19, 14:46

  20. Daniel Goerz voted on patch set 5 V +1 11/09/19, 15:18

  21. Benni Mack voted on patch set 5 V +2 CR +2 11/09/19, 15:51

  22. Benni Mack merged patch set 6 11/09/19, 15:51