Review main Merged

59894[TASK] Allow multiple extractor services with the same priority

Susi Moog CR +2 V +2 Easy +8 −6 updated 08/23/19, 15:14

Commit message

When having multiple extractor services with the same priority one
gets overwritten by the other. As extensions are free to deliver and
declare extractors, this cannot be fixed on 3rd party level.

ExtractorRegistry has been changed to allow registering multiple
extractors with same priority.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Tobi Kretschmann +1
    • Julian Geils +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Tobi Kretschmann +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1825

  1. Susi Moog uploaded patch set 1 03/07/19, 10:26

  2. TYPO3com voted on patch set 1 V +1 03/07/19, 10:42 Completed build in 15m 38s on Thu, 7 Mar, 11:42 AM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32574

  3. Tobi Kretschmann voted on patch set 1 CR +1 04/12/19, 09:57

  4. Frank Nägler commented on patch set 1 05/13/19, 20:04

    ExtractorRegistry.php:102

    I think this code could be simplified with: if (empty($filteredExtractors[$priority])) { $filteredExtractors[$priority] = []; } $filteredExtractors[$priority][] = $extractorObject; this way, we have every time an array and the code in ExtractorService::extractMetaData could be simplified also (no if/else), simply iterate over the array.
  5. Susi Moog commented on patch set 1 CR -1 05/13/19, 20:41

    ExtractorRegistry.php:102 Reply Unresolved

    sounds good.
  6. Susi Moog uploaded patch set 2 05/21/19, 06:40

  7. TYPO3com voted on patch set 2 V -1 05/21/19, 06:52 Completed build in 11m 51s on Tue, 21 May, 08:52 AM Test Summary: 91 of 46767 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33955

  8. Susi Moog uploaded patch set 3 05/21/19, 07:32

  9. TYPO3com voted on patch set 3 V -1 05/21/19, 07:45 Completed build in 13m 00s on Tue, 21 May, 09:45 AM Test Summary: 4 of 46844 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33956

  10. Susi Moog uploaded patch set 4 05/21/19, 07:50

  11. TYPO3com voted on patch set 4 V +1 05/21/19, 08:03 Completed build in 13m 17s on Tue, 21 May, 10:03 AM Test Summary: 46505 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-33957

  12. Julian Geils commented on patch set 4 CR +1 07/08/19, 09:40

    ExtractorRegistry.php:101

    i think this could be written with OR-Condition instead of IF/ELSEIF: if (empty($extractorObject->getDriverRestrictions()) || (in_array($driverType, $extractorObject->getDriverRestrictions()))) { $filteredExtractors[$priority][] = $extractorObject; }
  13. Jörg Bösche commented on patch set 4 CR -1 07/08/19, 13:54

    ExtractorService.php:43

    Can we use the null coalesce operator instead of using is_array?
  14. Susi Moog commented on patch set 4 07/08/19, 17:24

    ExtractorService.php:43 Reply

    go ahead and do it ;)
  15. Jörg Bösche uploaded patch set 5 07/09/19, 06:44

  16. Jörg Bösche commented on patch set 5 07/09/19, 06:45

    ExtractorRegistry.php:101 Reply

    Done

    ExtractorService.php:43 Reply

    Done
  17. TYPO3com voted on patch set 5 V +1 07/09/19, 06:56 Completed build in 11m 05s on Tue, 9 Jul, 08:56 AM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34853

  18. Dieter Porth uploaded patch set 6 07/10/19, 12:36

  19. TYPO3com voted on patch set 6 V -1 07/10/19, 12:49 Completed build in 12m 51s on Wed, 10 Jul, 02:49 PM Test Summary: 91 of 47020 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34886

  20. Tobi Kretschmann uploaded patch set 7 07/10/19, 13:53

  21. TYPO3com voted on patch set 7 V +1 07/10/19, 14:05 Completed build in 11m 35s on Wed, 10 Jul, 04:05 PM Test Summary: 46734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-34889

  22. Tobi Kretschmann commented on patch set 7 V +1 CR +1 07/11/19, 07:17

    I rolled back to Susi's patch with one little change in the Extractor Registry.
  23. Julian Geils voted on patch set 7 CR +1 07/11/19, 08:51

  24. Anja Leichsenring voted on patch set 7 V +2 CR +2 08/23/19, 15:14

  25. Anja Leichsenring merged patch set 8 08/23/19, 15:14