Review main Merged

59897[FEATURE] Allow sorting by file metadata "Title" in CE FileLinks

Susi Moog CR +2 V +2 Easy +36 −1 updated 03/07/19, 17:14

Commit message

FAL allows sorting by all metadata properties, the content element
file links had no interface for that until now. The possibility to sort
by the meta data "title" has been introduced. As "title" is provided by
the core, we can be sure that the field exists.

All other fields should be implemented by the integrators by extending
TCA.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 79

  1. Susi Moog uploaded patch set 1 03/07/19, 14:19

  2. TYPO3com voted on patch set 1 V -1 03/07/19, 14:30 Completed build in 10m 44s on Thu, 7 Mar, 03:30 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32578

  3. Guido Schmechel commented on patch set 1 03/07/19, 14:57

    Feature-56213-AllowSortingFilelistByFileMetadataTitle.rst:9

    Maybe you can provide a short example?
  4. Susi Moog uploaded patch set 2 03/07/19, 15:14

  5. TYPO3com voted on patch set 2 V +1 03/07/19, 15:30 Completed build in 16m 00s on Thu, 7 Mar, 04:30 PM Test Summary: 46812 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32579

  6. Susi Moog commented on patch set 2 03/07/19, 15:41

    Feature-56213-AllowSortingFilelistByFileMetadataTitle.rst:9 Reply

    Done for both PHP and TSConfig.
  7. Benni Mack voted on patch set 2 V +1 CR +1 03/07/19, 15:47

  8. Georg Ringer voted on patch set 2 V +2 CR +2 03/07/19, 17:14

  9. Georg Ringer merged patch set 3 03/07/19, 17:14