Review main Merged

59901[BUGFIX] Catch ExpressionLanguage exception for invalid base variants

Benni Mack CR +2 V +2 Normal +39 −28 updated 03/08/19, 08:42

Commit message

When adding an invalid expression for base variants,
an error is now caught instead of breaking the system.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 710

  1. Benni Mack uploaded patch set 1 03/07/19, 18:43

  2. Benni Mack rebased onto patch set 2 03/08/19, 06:55

  3. TYPO3com voted on patch set 2 V +1 03/08/19, 07:08 Completed build in 13m 07s on Fri, 8 Mar, 08:08 AM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32597

  4. Susi Moog updated the commit message in patch set 3 03/08/19, 08:21

  5. Susi Moog updated the commit message in patch set 4 03/08/19, 08:21

  6. Susi Moog voted on patch set 4 V +1 CR +1 03/08/19, 08:32

  7. TYPO3com voted on patch set 3 V +1 03/08/19, 08:36 Completed build in 14m 49s on Fri, 8 Mar, 09:36 AM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32598

  8. TYPO3com voted on patch set 4 V +1 03/08/19, 08:36 Completed build in 14m 37s on Fri, 8 Mar, 09:36 AM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32599

  9. Georg Ringer voted on patch set 4 V +2 CR +2 03/08/19, 08:42

  10. Georg Ringer merged patch set 5 03/08/19, 08:42