Review 9.5 Merged

59912[BUGFIX] Do not treat all classes as entities in ClassSchema

Anja Leichsenring CR +2 V +2 Easy +9 −3 updated 03/10/19, 07:26

Commit message

The ClassSchema class has a property $modelType which indicates
that a class is either an entity or a value object. This property
has a default value that reflected the state of an entity.

This means, that all classes, class schemata are created for are
considered entities which then leads to the execution of further
entity related analysis code, such as looking for specific doc
blocks and/or annotations.

While this isn't an issue functionality wise, it can be in the future.
Also, the superfluous cpu cycles can and should be spared.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
  • Verified V +2 Done
    • Anja Leichsenring +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 34

  1. Anja Leichsenring uploaded patch set 1 03/07/19, 19:47

  2. TYPO3com voted on patch set 1 V +1 03/07/19, 20:01 Completed build in 14m 05s on Thu, 7 Mar, 09:01 PM Test Summary: 49540 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-342

  3. Anja Leichsenring voted on patch set 1 V +2 CR +2 03/10/19, 07:26

  4. Anja Leichsenring merged patch set 2 03/10/19, 07:26