Review main Abandoned

59925[BUGFIX] Fix the caching of records in getPageForRootline

Kevin Ditscheid CR 0 V 0 Easy +1 −1 updated 09/25/19, 06:03

Commit message

This commit fixes the identifier for the record cache by making it
respect the given additionalFields array

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 67

  1. Kevin Ditscheid uploaded patch set 1 03/08/19, 13:03

  2. TYPO3com voted on patch set 1 V +1 03/08/19, 13:16 Completed build in 12m 43s on Fri, 8 Mar, 02:16 PM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32612

  3. Oliver Klee commented on patch set 1 03/08/19, 15:29

    BackendUtility.php:409

    I propose moving this to a well-named local variable to make this more readable.
  4. Kevin Ditscheid commented on patch set 1 03/08/19, 15:41

    BackendUtility.php:409 Reply

    Like $additionalFieldsPostfix?
  5. Oliver Klee commented on patch set 1 03/08/19, 15:59

    Is 8.7 affected as well?

    BackendUtility.php:409 Reply Unresolved

    Sounds good.
  6. Markus Klein commented on patch set 1 03/08/19, 16:04

    Good finding. thanks. regarding v8.7 fix please get in touch with Benni, he has to authorize that
  7. Kevin Ditscheid abandoned the change 09/25/19, 06:03

    Fixed in #60263