59952[TASK] Extract ValidatorClassNameResolver from ValidatorResolver
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Susi Moog +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+3 −8
- typo3/sysext/extbase/Classes/Validation/ValidatorClassNameResolver.phpnew+121 −0
- typo3/sysext/extbase/Classes/Validation/ValidatorResolver.php+1 −92
- typo3/sysext/extbase/Tests/Fixture/ValidatorThatDoesNotImplementValidatorInterfaceValidator.phpnew+24 −0
- typo3/sysext/extbase/Tests/Functional/Validation/ValidatorResolverTest.php+0 −96
- typo3/sysext/extbase/Tests/Unit/Validation/ValidatorClassNameResolverTest.php4new+177 −0
- typo3/sysext/extbase/Tests/Unit/Validation/ValidatorResolverTest.phpdeleted+0 −65
Review log 1014
-
Alexander Schnitzler uploaded patch set 1 03/09/19, 11:37
-
TYPO3com voted on patch set 1 V -1 03/09/19, 11:49 Completed build in 12m 38s on Sat, 9 Mar, 12:49 PM Test Summary: 1 of 47609 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32623
-
TYPO3com voted on patch set 1 V +1 03/09/19, 11:53 Completed build in 28m 33s on Sat, 9 Mar, 12:53 PM Test Summary: 47216 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32623
-
Alexander Schnitzler uploaded patch set 2 03/09/19, 12:07
-
TYPO3com voted on patch set 2 V +1 03/09/19, 12:21 Completed build in 14m 05s on Sat, 9 Mar, 01:21 PM Test Summary: 47216 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32624
-
Alexander Schnitzler commented on patch set 2 03/09/19, 13:49
This change is ready for review. -
Alexander Schnitzler wrote 03/12/19, 11:23
Topic set to extbase -
Susi Moog commented on patch set 2 CR -1 03/12/19, 20:32
ValidatorClassNameResolverTest.php:118Unresolvedthis and the following tests should probably start with only "resolve" instead of "resolveValidatorObjectName"ValidatorClassNameResolverTest.php:141Unresolvedshould this be "ThrowsException" ?ValidatorClassNameResolverTest.php:153Unresolvedthis - and the following tests - should use `assertSame` - additionally this test is the same as the first afaics.ValidatorClassNameResolverTest.php:181Unresolvedthis test is duplicated to the one with the same exception code above -
Alexander Schnitzler uploaded patch set 3 03/14/19, 18:23
-
TYPO3com voted on patch set 3 V +1 03/14/19, 18:34 Completed build in 11m 21s on Thu, 14 Mar, 07:34 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32732
-
Susi Moog voted on patch set 3 CR +1 03/15/19, 13:33
-
Susi Moog commented on patch set 3 V +1 03/15/19, 13:48
btw didn't even know that "TYPO3.CMS.Extbase:NotEmpty" existed... "again what learned" -
Anja Leichsenring voted on patch set 3 V +2 CR +2 03/15/19, 15:24
-
Anja Leichsenring merged patch set 4 03/15/19, 15:24