Review main Merged

59952[TASK] Extract ValidatorClassNameResolver from ValidatorResolver

Alexander Schnitzler CR +2 V +2 Hard +326 −261 updated 03/15/19, 15:24

Commit message

The ValidatorResolver contained a method for resolving validator
class names. Extbase supports various shorthand notations to
make the life of developers more easy. There are notations like:

- NotEmpty
- TYPO3.CMS.Extbase:NotEmpty
- CustomExtension:ValidatorName

Resolving these notations takes place in a dedicated
ValidatorClassNameResolver class now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 7

Review log 1014

  1. Alexander Schnitzler uploaded patch set 1 03/09/19, 11:37

  2. TYPO3com voted on patch set 1 V -1 03/09/19, 11:49 Completed build in 12m 38s on Sat, 9 Mar, 12:49 PM Test Summary: 1 of 47609 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32623

  3. TYPO3com voted on patch set 1 V +1 03/09/19, 11:53 Completed build in 28m 33s on Sat, 9 Mar, 12:53 PM Test Summary: 47216 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32623

  4. Alexander Schnitzler uploaded patch set 2 03/09/19, 12:07

  5. TYPO3com voted on patch set 2 V +1 03/09/19, 12:21 Completed build in 14m 05s on Sat, 9 Mar, 01:21 PM Test Summary: 47216 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32624

  6. Alexander Schnitzler commented on patch set 2 03/09/19, 13:49

    This change is ready for review.
  7. Alexander Schnitzler wrote 03/12/19, 11:23

    Topic set to extbase
  8. Susi Moog commented on patch set 2 CR -1 03/12/19, 20:32

    ValidatorClassNameResolverTest.php:118 Unresolved

    this and the following tests should probably start with only "resolve" instead of "resolveValidatorObjectName"

    ValidatorClassNameResolverTest.php:141 Unresolved

    should this be "ThrowsException" ?

    ValidatorClassNameResolverTest.php:153 Unresolved

    this - and the following tests - should use `assertSame` - additionally this test is the same as the first afaics.

    ValidatorClassNameResolverTest.php:181 Unresolved

    this test is duplicated to the one with the same exception code above
  9. Alexander Schnitzler uploaded patch set 3 03/14/19, 18:23

  10. TYPO3com voted on patch set 3 V +1 03/14/19, 18:34 Completed build in 11m 21s on Thu, 14 Mar, 07:34 PM Test Summary: 47215 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32732

  11. Susi Moog voted on patch set 3 CR +1 03/15/19, 13:33

  12. Susi Moog commented on patch set 3 V +1 03/15/19, 13:48

    btw didn't even know that "TYPO3.CMS.Extbase:NotEmpty" existed... "again what learned"
  13. Anja Leichsenring voted on patch set 3 V +2 CR +2 03/15/19, 15:24

  14. Anja Leichsenring merged patch set 4 03/15/19, 15:24