Review main Merged

59954[TASK] Replace strings with constants/variables

Benni Mack CR +2 V +2 Easy +6 −6 updated 03/11/19, 10:32

Commit message

There are a few places where - instead of hard-coded values,
the proper constants or variables can be used instead.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Stephan Großberndt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 78

  1. Benni Mack uploaded patch set 1 03/09/19, 12:55

  2. TYPO3com voted on patch set 1 V +1 03/09/19, 13:05 Completed build in 09m 37s on Sat, 9 Mar, 02:05 PM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32626

  3. Stephan Großberndt voted on patch set 1 CR +1 03/09/19, 13:08

  4. Georg Ringer voted on patch set 1 V +1 CR +1 03/09/19, 15:25

  5. Oliver Klee voted on patch set 1 CR +1 03/10/19, 11:33

  6. Josef Glatz voted on patch set 1 V +1 CR +1 03/10/19, 23:36

  7. Benni Mack voted on patch set 1 V +2 CR +2 03/11/19, 10:32

  8. Benni Mack merged patch set 2 03/11/19, 10:32