Review 9.5 Merged

59956[BUGFIX] GifBuilder returns already generated images

Benni Mack CR +2 V +2 Normal +91 −4 updated 03/09/19, 14:34

Commit message

When combining image files with gifbuilder, the hash to identify the
resulting file is now stable with respect to the fact whether the
files are cropped or scaled in the current request or already cropped
before. That leads to stable hashes whenever the same images are
processed with the same configuration, and allows reuse as intended.

Also ensure that fileInfo returned from ContentObjectRenderer contains
width and height information as int, when they are returned from
database as that may lead to different serialized representations of the
configuration

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 3

Review log 45

  1. Benni Mack commented on patch set 1 03/09/19, 13:48

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/09/19, 14:02 Completed build in 13m 43s on Sat, 9 Mar, 03:02 PM Test Summary: 49928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-362

  3. Oliver Hader voted on patch set 1 CR +1 03/09/19, 14:18

  4. Benni Mack voted on patch set 1 V +2 CR +2 03/09/19, 14:34

  5. Benni Mack merged patch set 2 03/09/19, 14:34