59958[BUGFIX] Allow umlaut domains for site domain resolving
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Hader +1
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Hader +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 2
Files 4
Review log 1621
-
Benni Mack uploaded patch set 1 03/09/19, 14:32
-
Benni Mack updated the commit message in patch set 2 03/09/19, 14:43
-
TYPO3com voted on patch set 1 V +1 03/09/19, 14:49 Completed build in 16m 16s on Sat, 9 Mar, 03:49 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32634
-
TYPO3com voted on patch set 2 V +1 03/09/19, 14:57 Completed build in 13m 57s on Sat, 9 Mar, 03:57 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32635
-
Oliver Klee updated the commit message in patch set 3 03/09/19, 15:26
-
Georg Ringer voted on patch set 3 V +1 CR +1 03/09/19, 15:28
-
TYPO3com voted on patch set 3 V +1 03/09/19, 15:42 Completed build in 15m 54s on Sat, 9 Mar, 04:42 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32636
-
Oliver Klee commented on patch set 3 03/09/19, 15:43
Should we cover this with tests? -
Benni Mack commented on patch set 3 03/09/19, 15:44
Hi Oli, this is covered with tests. I modified the SiteRequestTest (which calls the SiteMatcher). without adding the idna_* methods, the tests then fail. -
Susi Moog commented on patch set 3 03/11/19, 20:39
SiteRequestTest.php:279Unresolveddid you mean "umlaut" ? -
Benni Mack commented on patch set 4 03/12/19, 05:40
Published edit on patch set 3. -
TYPO3com voted on patch set 4 V +1 03/12/19, 06:00 Completed build in 15m 57s on Tue, 12 Mar, 07:00 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32668
-
Oliver Hader uploaded patch set 5 03/12/19, 17:16
-
TYPO3com voted on patch set 5 V +1 03/12/19, 17:30 Completed build in 14m 17s on Tue, 12 Mar, 06:30 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32679
-
Oliver Hader voted on patch set 5 V +1 CR +1 03/12/19, 17:39
-
Susi Moog voted on patch set 5 CR +1 03/12/19, 19:23
-
Susi Moog voted on patch set 5 V +1 03/12/19, 19:47
-
Oliver Hader voted on patch set 5 V +2 CR +2 03/12/19, 21:42
-
Oliver Hader voted on patch set 5 V +1 CR +1 03/12/19, 21:50
-
Benni Mack voted on patch set 5 V +2 CR +2 03/13/19, 05:20
-
Benni Mack merged patch set 6 03/13/19, 05:20