Review TYPO3_8-7 Merged

59959[BUGFIX] GifBuilder returns already generated images

Benni Mack CR +2 V +2 Normal +92 −4 updated 03/09/19, 19:00

Commit message

When combining image files with gifbuilder, the hash to identify the
resulting file is now stable with respect to the fact whether the
files are cropped or scaled in the current request or already cropped
before. That leads to stable hashes whenever the same images are
processed with the same configuration, and allows reuse as intended.

Also ensure that fileInfo returned from ContentObjectRenderer contains
width and height information as int, when they are returned from
database as that may lead to different serialized representations of the
configuration

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 3

Files 3

Review log 57

  1. Benni Mack uploaded patch set 1 03/09/19, 14:40

  2. TYPO3com voted on patch set 1 V -1 03/09/19, 15:05 Completed build in 24m 41s on Sat, 9 Mar, 04:05 PM Test Summary: 2 of 80754 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3442

  3. Benni Mack uploaded patch set 2 03/09/19, 15:13

  4. Oliver Klee voted on patch set 2 CR +1 03/09/19, 15:25

  5. TYPO3com voted on patch set 2 V +1 03/09/19, 16:13 Completed build in 39m 00s on Sat, 9 Mar, 05:12 PM Test Summary: 80206 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3443

  6. Benni Mack voted on patch set 2 V +2 CR +2 03/09/19, 19:00

  7. Benni Mack merged patch set 3 03/09/19, 19:00