Review TYPO3_8-7 Merged

59961[BUGFIX] Pass original DBALException along with SqlErrorException

Georg Ringer CR +2 V +2 Easy +12 −12 updated 08/05/19, 13:56

Commit message

When a
TYPO3\CMS\Extbase\Persistence\Generic\Storage\Exception\SqlErrorException
is thrown, pass the previous exception as 3rd parameter to the
constructor, to get the real reason for the exception.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Georg Ringer commented on patch set 1 03/09/19, 15:27

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/09/19, 15:52 Completed build in 24m 47s on Sat, 9 Mar, 04:52 PM Test Summary: 80204 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3444

  3. Susi Moog voted on patch set 1 CR +1 03/12/19, 20:01

  4. Susi Moog voted on patch set 1 V +1 03/12/19, 20:23

  5. Oliver Klee voted on patch set 1 CR +1 03/13/19, 13:32

  6. Tomas Norre Mikkelsen voted on patch set 1 CR +1 03/14/19, 07:41

  7. Andreas Kienast rebased onto patch set 2 08/05/19, 13:24

  8. TYPO3com voted on patch set 2 V -1 08/05/19, 13:52 Completed build in 26m 22s on Mon, 5 Aug, 01:52 PM Test Summary: 80366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3584

  9. TYPO3com voted on patch set 2 V +1 08/05/19, 13:56 Completed build in 57m 00s on Mon, 5 Aug, 01:56 PM Test Summary: 80366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3584

  10. Andreas Kienast voted on patch set 2 V +2 CR +2 08/05/19, 13:56

  11. Andreas Kienast merged patch set 3 08/05/19, 13:56