Review main Merged

59972[BUGFIX] Add field static_page_arguments to group by of query

Georg Ringer CR +2 V +2 Easy +2 −1 updated 03/13/19, 16:56

Commit message

With #86994 a new field has been added to the database table
`index_phash`. This fields needs to be added to the GROUP BY
statement as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josef Glatz +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Georg Ringer uploaded patch set 1 03/09/19, 15:39

  2. Georg Ringer commented on patch set 1 03/09/19, 15:39

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/09/19, 15:53 Completed build in 14m 15s on Sat, 9 Mar, 04:53 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32638

  4. Josef Glatz voted on patch set 1 CR +1 03/09/19, 22:06

  5. Susi Moog commented on patch set 1 V +1 CR +1 03/11/19, 20:57

    though correct we should probably think about performance improvements for indexed search somewhen in the future. group by "blob" is notoriously slow...
  6. Benni Mack commented on patch set 1 V +2 CR +2 03/13/19, 16:56

    agreed @susi. let's dig deeper here separately.
  7. Benni Mack merged patch set 2 03/13/19, 16:56