Review main Merged

59993[BUGFIX] Include Records with "All Languages" in default language

Benni Mack CR +2 V +2 Easy +2 −2 updated 03/12/19, 05:39

Commit message

Records with "All Languages" (sys_language_uid=-1)
aren't shown in TYPO3 v9 anymore of the default
language.

This happened before in TYPO3 v8 and below,
however setting config.sys_language_overlay = 1
triggered the if() condition to jump into the
selection of fetching 0 and -1 records.

As this setting is removed, the check only
applies when overlays are activated, which
is not necessary in language=0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 68

  1. Benni Mack uploaded patch set 1 03/09/19, 18:40

  2. Benni Mack updated the commit message in patch set 2 03/09/19, 18:42

  3. TYPO3com voted on patch set 1 V -1 03/09/19, 18:52 Completed build in 12m 05s on Sat, 9 Mar, 07:52 PM Test Summary: 1 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32640

  4. TYPO3com voted on patch set 2 V +1 03/09/19, 18:58 Completed build in 15m 24s on Sat, 9 Mar, 07:57 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32641

  5. Georg Ringer voted on patch set 2 V +1 CR +1 03/11/19, 15:04

  6. Susi Moog voted on patch set 2 V +1 CR +1 03/11/19, 20:38

  7. Benni Mack voted on patch set 2 V +2 CR +2 03/12/19, 05:38

  8. Benni Mack merged patch set 3 03/12/19, 05:39