Review main Merged

60112[TASK] Remove loading of FileListLocalisation in FormEngine

Susi Moog CR +2 V +2 Easy +0 −2 updated 03/13/19, 17:20

Commit message

The FileListLocalisation requirejs module has been removed from
FormResultCompiler. The module is used for displaying translation
toggles in the file list module (and only there).

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Björn Jacob +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Björn Jacob +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 78

  1. Susi Moog uploaded patch set 1 03/11/19, 13:03

  2. Georg Ringer commented on patch set 1 V +1 CR +1 03/11/19, 16:38

    I would even remove that for 9
  3. TYPO3com voted on patch set 1 V +1 03/11/19, 18:27 Completed build in 09m 53s on Mon, 11 Mar, 07:27 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32660

  4. Björn Jacob voted on patch set 1 V +1 CR +1 03/11/19, 18:38

  5. Andreas Kienast voted on patch set 1 V +1 CR +1 03/13/19, 14:03

  6. Oliver Klee voted on patch set 1 CR +1 03/13/19, 14:33

  7. Benni Mack voted on patch set 1 V +2 CR +2 03/13/19, 17:20

  8. Benni Mack merged patch set 2 03/13/19, 17:20