Review main Merged

60153[TASK] Move filelist related controllers to filelist

Susi Moog CR +2 V +2 Nightmare +1549 −1288 updated 01/12/20, 14:47

Commit message

The following controllers have been moved to filelist as they are
part of filelist functionality and not called anywhere else:

- `CreateFolderController`
- `EditFileController`
- `FileUploadController`
- `RenameFileController`
- `ReplaceFileController`

In addition the TypeScript module `RenameFile` has also been moved to
EXT:filelist.

The base file function route `tce_file` has not been changed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 2

Files 30

Show 10 more files

Review log 1524

  1. Susi Moog uploaded patch set 1 03/11/19, 16:21

  2. TYPO3com voted on patch set 1 V +1 03/11/19, 16:36 Completed build in 15m 19s on Mon, 11 Mar, 05:36 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32654

  3. Susi Moog uploaded patch set 2 03/11/19, 17:48

  4. TYPO3com voted on patch set 2 V -1 03/11/19, 17:49 Completed build in 16s on Mon, 11 Mar, 06:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32657

  5. Susi Moog uploaded patch set 3 03/11/19, 17:50

  6. Susi Moog commented on patch set 3 03/11/19, 18:16

    This change is ready for review.
  7. TYPO3com voted on patch set 3 V +1 03/11/19, 18:19 Completed build in 13m 32s on Mon, 11 Mar, 07:19 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32659

  8. Andreas Kienast commented on patch set 3 CR -1 03/13/19, 14:18

    on it
  9. Andreas Kienast uploaded patch set 4 03/13/19, 14:33

  10. Andreas Kienast uploaded patch set 5 03/13/19, 14:34

  11. TYPO3com voted on patch set 4 V +1 03/13/19, 14:51 Completed build in 17m 59s on Wed, 13 Mar, 03:51 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32698

  12. TYPO3com voted on patch set 5 V -1 03/13/19, 14:55 Completed build in 16m 48s on Wed, 13 Mar, 03:55 PM Test Summary: 1 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32699

  13. TYPO3com voted on patch set 5 V +1 03/13/19, 16:03 Completed build in 1h 40m 49s on Wed, 13 Mar, 05:03 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32699

  14. Susi Moog updated the commit message in patch set 6 03/13/19, 17:17

  15. TYPO3com voted on patch set 6 V +1 03/13/19, 17:33 Completed build in 15m 53s on Wed, 13 Mar, 06:33 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32706

  16. Andreas Kienast voted on patch set 6 V +1 CR +1 03/14/19, 08:08

  17. Anja Leichsenring commented on patch set 7 03/15/19, 11:42

    Published edit on patch set 6.
  18. Anja Leichsenring commented on patch set 8 03/15/19, 11:43

    Published edit on patch set 7.
  19. TYPO3com voted on patch set 7 V +1 03/15/19, 11:58 Completed build in 16m 06s on Fri, 15 Mar, 12:58 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32747

  20. TYPO3com voted on patch set 8 V +1 03/15/19, 11:59 Completed build in 15m 51s on Fri, 15 Mar, 12:59 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32748

  21. Anja Leichsenring voted on patch set 8 V +1 CR +1 03/15/19, 12:03

  22. Andreas Kienast voted on patch set 8 V +2 CR +2 03/15/19, 12:30

  23. Andreas Kienast merged patch set 9 03/15/19, 12:30

  24. Markus Klein commented on patch set 9 01/12/20, 14:47

    locallang_core.xlf:686 Unresolved

    still referenced here in View/FolderUtilityRenderer.php