Review main Merged

60154[TASK] Replace styles.content.get in Install Tool created TS

Georg Ringer CR +2 V +2 Easy +9 −1 updated 03/11/19, 21:01

Commit message

Use cObject CONTENT directly instead of using styles.content.get

Review

  • Code review CR +2 Done
    • Markus Klein +2
    • Joerg Kummer +1
    • Susi Moog +1
  • Verified V +2 Done
    • Markus Klein +2
    • Joerg Kummer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1213

  1. Georg Ringer uploaded patch set 1 03/11/19, 16:29

  2. Georg Ringer commented on patch set 1 03/11/19, 16:30

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/11/19, 16:43 Completed build in 13m 30s on Mon, 11 Mar, 05:43 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32655

  4. Markus Klein voted on patch set 1 CR +1 03/11/19, 16:53

  5. Joerg Kummer voted on patch set 1 CR +1 03/11/19, 17:26

  6. Björn Jacob commented on patch set 1 03/11/19, 18:40

    InstallerController.php:801

    Why do you have to "escape" it this way? Am I stupid? I used to write where = colPos=0
  7. Joerg Kummer commented on patch set 1 03/11/19, 20:26

    > Patch Set 1: > > (1 comment) It is required for DBal compatible field quoting since 8.7 https://docs.typo3.org/typo3cms/extensions/core/Changelog/8.7/Important-80506-DbalCompatibleFieldQuotingInTypoScript.html
  8. Markus Klein voted on patch set 1 V +1 03/11/19, 20:34

  9. Joerg Kummer voted on patch set 1 V +1 03/11/19, 20:51

  10. Susi Moog commented on patch set 1 03/11/19, 20:53

    InstallerController.php:801 Reply Unresolved

  11. Susi Moog voted on patch set 1 V +1 CR +1 03/11/19, 20:54

  12. Markus Klein voted on patch set 1 V +2 CR +2 03/11/19, 21:01

  13. Markus Klein merged patch set 2 03/11/19, 21:01