60154[TASK] Replace styles.content.get in Install Tool created TS
Commit message
Review
-
Code review CR +2 Done
- Markus Klein +2
- Joerg Kummer +1
- Susi Moog +1
-
Verified V +2 Done
- Markus Klein +2
- Joerg Kummer +1
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1213
-
Georg Ringer uploaded patch set 1 03/11/19, 16:29
-
Georg Ringer commented on patch set 1 03/11/19, 16:30
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 03/11/19, 16:43 Completed build in 13m 30s on Mon, 11 Mar, 05:43 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32655
-
Markus Klein voted on patch set 1 CR +1 03/11/19, 16:53
-
Joerg Kummer voted on patch set 1 CR +1 03/11/19, 17:26
-
Björn Jacob commented on patch set 1 03/11/19, 18:40
InstallerController.php:801Why do you have to "escape" it this way? Am I stupid? I used to write where = colPos=0 -
Joerg Kummer commented on patch set 1 03/11/19, 20:26
> Patch Set 1: > > (1 comment) It is required for DBal compatible field quoting since 8.7 https://docs.typo3.org/typo3cms/extensions/core/Changelog/8.7/Important-80506-DbalCompatibleFieldQuotingInTypoScript.html -
Markus Klein voted on patch set 1 V +1 03/11/19, 20:34
-
Joerg Kummer voted on patch set 1 V +1 03/11/19, 20:51
-
Susi Moog commented on patch set 1 03/11/19, 20:53
InstallerController.php:801Reply Unresolvednot stupid, just old :-P https://docs.typo3.org/typo3cms/CoreApiReference/ApiOverview/Database/Migration/Index.html#tca-and-typoscript << ;) -
Susi Moog voted on patch set 1 V +1 CR +1 03/11/19, 20:54
-
Markus Klein voted on patch set 1 V +2 CR +2 03/11/19, 21:01
-
Markus Klein merged patch set 2 03/11/19, 21:01