Review main Merged

60155[TASK] Remove needless string concatenations

Georg Ringer CR +2 V +2 Normal +99 −99 updated 03/15/19, 13:08

Commit message

Replace string concatenations like 'abc' . 'def' with 'abcdef'.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 38

Show 18 more files

Review log 1418

  1. Georg Ringer uploaded patch set 1 03/11/19, 16:57

  2. Georg Ringer commented on patch set 1 03/11/19, 16:57

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/11/19, 17:11 Completed build in 13m 20s on Mon, 11 Mar, 06:11 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32656

  4. Markus Klein updated the commit message in patch set 2 03/11/19, 20:02

  5. TYPO3com voted on patch set 2 V +1 03/11/19, 20:16 Completed build in 12m 55s on Mon, 11 Mar, 09:16 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32662

  6. Markus Klein commented on patch set 2 03/11/19, 20:31

    InlineRecordContainer.php:555 Unresolved

    missing space?

    InlineRecordContainer.php:562 Unresolved

    missing space?
  7. Georg Ringer uploaded patch set 3 03/12/19, 20:18

  8. TYPO3com voted on patch set 3 V +1 03/12/19, 20:29 Completed build in 10m 48s on Tue, 12 Mar, 09:29 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32682

  9. Markus Klein voted on patch set 3 CR +1 03/13/19, 21:28

  10. Guido Schmechel commented on patch set 3 03/14/19, 10:24

    TableGarbageCollectionAdditionalFieldProvider.php:174

    With $disabled we have id="foobar" disabled="disabled"value="1" (two spaces after id and none before value)
  11. Markus Klein commented on patch set 4 03/14/19, 10:31

    Published edit on patch set 3.
  12. Markus Klein voted on patch set 4 CR +1 03/14/19, 10:33

  13. Guido Schmechel commented on patch set 4 CR +1 03/14/19, 10:33

    TableGarbageCollectionAdditionalFieldProvider.php:174 Reply

    Done
  14. TYPO3com voted on patch set 4 V +1 03/14/19, 10:46 Completed build in 14m 32s on Thu, 14 Mar, 11:46 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32723

  15. Daniel Goerz voted on patch set 4 V +1 CR +1 03/14/19, 22:18

  16. Markus Klein commented on patch set 4 V +1 03/15/19, 07:51

    Tested as much as possible
  17. Daniel Goerz voted on patch set 4 V +2 CR +2 03/15/19, 13:07

  18. Daniel Goerz merged patch set 5 03/15/19, 13:08