60155[TASK] Remove needless string concatenations
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Markus Klein +1
- Guido Schmechel +1
-
Verified V +2 Done
- Daniel Goerz +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 38
- typo3/sysext/backend/Classes/Controller/FormFlexAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Controller/FormInlineAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Controller/NewRecordController.php+1 −1
- typo3/sysext/backend/Classes/Controller/SiteInlineAjaxController.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/FlexFormSectionContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php+1 −1
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php2+4 −4
- typo3/sysext/backend/Classes/Form/InlineStackProcessor.php+2 −2
- typo3/sysext/backend/Classes/Tree/View/PagePositionMap.php+1 −1
- typo3/sysext/backend/Classes/View/PageLayoutView.php+5 −5
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/MemcachedBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/PdoBackend.php+1 −1
- typo3/sysext/core/Classes/Cache/Backend/SimpleFileBackend.php+1 −1
- typo3/sysext/core/Classes/Database/QueryGenerator.php+8 −8
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+2 −2
- typo3/sysext/core/Classes/FormProtection/FormProtectionFactory.php+1 −1
- typo3/sysext/core/Classes/Html/RteHtmlParser.php+1 −1
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+1 −1
- typo3/sysext/core/Classes/Resource/Service/UserFileInlineLabelService.php+1 −1
Show 18 more files
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+3 −3
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+1 −1
- typo3/sysext/core/Tests/Unit/Html/RteHtmlParserTest.php+30 −30
- typo3/sysext/core/Tests/Unit/Http/MiddlewareStackResolverTest.php+6 −6
- typo3/sysext/core/Tests/Unit/Utility/CommandUtilityTest.php+2 −2
- typo3/sysext/extensionmanager/Classes/Utility/Connection/TerUtility.php+2 −2
- typo3/sysext/fluid/Tests/Unit/ViewHelpers/FormViewHelperTest.php+2 −2
- typo3/sysext/frontend/Classes/Page/PageRepository.php+1 −1
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+2 −2
- typo3/sysext/install/Classes/Service/ExtensionConfigurationService.php+2 −2
- typo3/sysext/install/Classes/SystemEnvironment/Check.php+1 −1
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/reports/Classes/Report/Status/ConfigurationStatus.php+1 −1
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTaskNotificationEmailField.php+1 −1
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationAdditionalFieldProvider.php+2 −2
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php2+3 −3
Review log 1418
-
Georg Ringer uploaded patch set 1 03/11/19, 16:57
-
Georg Ringer commented on patch set 1 03/11/19, 16:57
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 03/11/19, 17:11 Completed build in 13m 20s on Mon, 11 Mar, 06:11 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32656
-
Markus Klein updated the commit message in patch set 2 03/11/19, 20:02
-
TYPO3com voted on patch set 2 V +1 03/11/19, 20:16 Completed build in 12m 55s on Mon, 11 Mar, 09:16 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32662
-
Markus Klein commented on patch set 2 03/11/19, 20:31
InlineRecordContainer.php:555Unresolvedmissing space?InlineRecordContainer.php:562Unresolvedmissing space? -
Georg Ringer uploaded patch set 3 03/12/19, 20:18
-
TYPO3com voted on patch set 3 V +1 03/12/19, 20:29 Completed build in 10m 48s on Tue, 12 Mar, 09:29 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32682
-
Markus Klein voted on patch set 3 CR +1 03/13/19, 21:28
-
Guido Schmechel commented on patch set 3 03/14/19, 10:24
TableGarbageCollectionAdditionalFieldProvider.php:174With $disabled we have id="foobar" disabled="disabled"value="1" (two spaces after id and none before value) -
Markus Klein commented on patch set 4 03/14/19, 10:31
Published edit on patch set 3. -
Markus Klein voted on patch set 4 CR +1 03/14/19, 10:33
-
Guido Schmechel commented on patch set 4 CR +1 03/14/19, 10:33
TableGarbageCollectionAdditionalFieldProvider.php:174ReplyDone -
TYPO3com voted on patch set 4 V +1 03/14/19, 10:46 Completed build in 14m 32s on Thu, 14 Mar, 11:46 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32723
-
Daniel Goerz voted on patch set 4 V +1 CR +1 03/14/19, 22:18
-
Markus Klein commented on patch set 4 V +1 03/15/19, 07:51
Tested as much as possible -
Daniel Goerz voted on patch set 4 V +2 CR +2 03/15/19, 13:07
-
Daniel Goerz merged patch set 5 03/15/19, 13:08