Review main Merged

60174[BUGFIX] Do not send empty scheduler status mails

Guido Schmechel CR +2 V +2 Easy +1 −2 updated 03/15/19, 19:41

Commit message

Due to a missing initialization, the status providers were not filled
in the status report in the scheduler task. The providers are now
initialized in the constructor and can now always be used.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Guido Schmechel uploaded patch set 1 03/11/19, 23:47

  2. TYPO3com voted on patch set 1 V +1 03/12/19, 11:47 Completed build in 12m 44s on Tue, 12 Mar, 12:47 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32673

  3. Susi Moog voted on patch set 1 CR +1 03/12/19, 19:49

  4. Susi Moog voted on patch set 1 V +1 03/12/19, 19:59

  5. Markus Klein commented on patch set 1 03/15/19, 13:31

    Did you check all the usages of this Status class? If I'm not mistaken this is used also somewhere in the install tool. Just to be sure that this change does not have any nasty side effect
  6. Markus Klein commented on patch set 1 V +1 CR +1 03/15/19, 13:32

    I checked myself... looks good
  7. Georg Ringer voted on patch set 1 V +2 CR +2 03/15/19, 19:41

  8. Georg Ringer merged patch set 2 03/15/19, 19:41