Review 9.5 Merged

60192[BUGFIX] Include Records with "All Languages" in default language

Benni Mack CR +2 V +2 Easy +2 −2 updated 04/29/19, 08:24

Commit message

Records with "All Languages" (sys_language_uid=-1)
aren't shown in TYPO3 v9 anymore of the default
language.

This happened before in TYPO3 v8 and below,
however setting config.sys_language_overlay = 1
triggered the if() condition to jump into the
selection of fetching 0 and -1 records.

As this setting is removed, the check only
applies when overlays are activated, which
is not necessary in language=0.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Michael +1
    • TYPO3com +1 CI

Issues 3

Files 1

Review log 67

  1. Benni Mack commented on patch set 1 03/12/19, 05:39

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/12/19, 05:57 Completed build in 17m 41s on Tue, 12 Mar, 06:57 AM Test Summary: 49928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-370

  3. Benni Mack voted on patch set 1 V +2 CR +2 03/12/19, 06:13

  4. Benni Mack merged patch set 2 03/12/19, 06:13

  5. Benni Mack commented on patch set 2 03/12/19, 08:58

    change has been merged, but still shows up in my list... strange
  6. Christian Michael commented on patch set 2 V +1 04/29/19, 08:12

    Fixes the bug in my TYPO3 9.5.5 project (please deploy it to the source code ;-)
  7. Benni Mack commented on patch set 2 04/29/19, 08:24

    next 9.5.6 release coming up in a week