Review 9.5 Merged

60232[BUGFIX] Allow umlaut domains for site domain resolving

Oliver Hader CR +2 V +2 Hard +327 −61 updated 03/13/19, 06:06

Commit message

As umlaut domains require to be puny-coded, this needs
to be added into the request context of the SiteMatcher.

A polyfill package "symfony/polyfill-intl-idn" is installed
to ensure that the methods exist at all times. If "ext-intl"
is not available, the polyfill package is used.

Installed via
    composer require symfony/polyfill-intl-idn

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 2

Files 5

Review log 46

  1. Oliver Hader uploaded patch set 1 03/12/19, 21:41

  2. TYPO3com voted on patch set 1 V +1 03/12/19, 21:54 Completed build in 12m 05s on Tue, 12 Mar, 10:54 PM Test Summary: 49928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-373

  3. Benni Mack uploaded patch set 2 03/13/19, 05:27

  4. TYPO3com voted on patch set 2 V +1 03/13/19, 05:53 Completed build in 18m 52s on Wed, 13 Mar, 06:53 AM Test Summary: 49928 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-374

  5. Benni Mack voted on patch set 2 V +2 CR +2 03/13/19, 06:06

  6. Benni Mack merged patch set 3 03/13/19, 06:06