60234[TASK] Use native idn functionality
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
- Stephan Großberndt +1
-
Verified V +2 Done
- Georg Ringer +2
- Benjamin Franzke +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −1
- typo3/sysext/core/Classes/Mail/MailMessage.php+2 −2
- typo3/sysext/core/Classes/Utility/GeneralUtility.php2+21 −30
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-87894-GeneralUtilityidnaEncode.rst2new+39 −0
- typo3/sysext/core/Documentation/Changelog/master/Important-87894-RemovedPHPDependencyAlgo26-matthiasidna-convert.rst2new+20 −0
- typo3/sysext/core/Tests/Unit/Utility/GeneralUtilityTest.php+0 −60
- typo3/sysext/core/Tests/UnitDeprecated/Utility/GeneralUtilityTest.phpnew+89 −0
- typo3/sysext/core/composer.json+0 −1
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php2+1 −1
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallStaticMatcher.php+7 −0
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php+1 −10
- composer.json+0 −1
- composer.lock+1 −50
Review log 2430
Show 45 earlier messages
-
Benni Mack uploaded patch set 1 03/13/19, 08:15
-
Stephan Großberndt marked it work in progress 03/13/19, 08:28
-
TYPO3com voted on patch set 1 V +1 03/13/19, 08:29 Completed build in 13m 31s on Wed, 13 Mar, 09:29 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32689
-
Benni Mack uploaded patch set 2 03/13/19, 08:41
-
Benni Mack commented on patch set 2 03/13/19, 08:42
This change is ready for review.
-
Stephan Großberndt commented on patch set 2 03/13/19, 08:50
Since we are in master "breaking" mode anyway, should we handle the removal as potentially breaking with an according "Breaking" RST instead of "Important"? -
Benni Mack commented on patch set 2 03/13/19, 08:51
In the past, we did not consider third-party packages as part of the API. So I consider it non-breaking. -
TYPO3com voted on patch set 2 V -1 03/13/19, 08:55 Completed build in 13m 44s on Wed, 13 Mar, 09:55 AM Test Summary: 36 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32690
-
Benni Mack uploaded patch set 3 03/13/19, 09:00
-
TYPO3com voted on patch set 3 V +1 03/13/19, 09:14 Completed build in 13m 20s on Wed, 13 Mar, 10:14 AM Test Summary: 47182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32691
-
Oliver Hader commented on patch set 3 03/13/19, 09:50
Probably there is one aspect we should enforce... it's about IDN 2003 vs. 2008 and others. Example: "fußball.de" should be "xn--fuball-cta.de", and not "fussball.de" (which it would be using IDN 2003) -
Oliver Hader commented on patch set 3 03/13/19, 09:51
-
Benni Mack commented on patch set 3 03/13/19, 10:31
> Patch Set 3: > > Probably there is one aspect we should enforce... it's about IDN 2003 vs. 2008 and others. > Example: "fußball.de" should be "xn--fuball-cta.de", and not "fussball.de" (which it would be using IDN 2003) I already documented this in the RST files. On top, IDN_2003 is deprecated since PHP 7.2 so this will trigger warnings if used in third-party extensions. -
Stephan Großberndt voted on patch set 3 CR +1 03/13/19, 20:21
-
Susi Moog commented on patch set 3 03/14/19, 07:19
GeneralUtility.php:884idn_to_asciiDeprecation-87894-GeneralUtilityidnaEncode.rst:34should we add a hint, that for email addresses they could split the domain part or is that too obvious?Important-87894-RemovedPHPDependencyAlgo26-matthiasidna-convert.rst:14add name? -
Stephan Großberndt commented on patch set 4 03/14/19, 20:12
Published edit on patch set 3. -
Stephan Großberndt commented on patch set 4 CR +1 03/14/19, 20:12
GeneralUtility.php:884ReplyDoneDeprecation-87894-GeneralUtilityidnaEncode.rst:34ReplyDoneImportant-87894-RemovedPHPDependencyAlgo26-matthiasidna-convert.rst:14ReplyDone -
TYPO3com voted on patch set 4 V +1 03/14/19, 20:28 Completed build in 15m 30s on Thu, 14 Mar, 09:28 PM Test Summary: 47182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32737
-
Georg Ringer commented on patch set 4 03/14/19, 22:00
PageLinkBuilder.php:472should there be a type cast? -
Stephan Großberndt commented on patch set 5 03/14/19, 22:42
Published edit on patch set 4. -
Stephan Großberndt commented on patch set 5 CR +1 03/14/19, 22:42
PageLinkBuilder.php:472ReplyDone -
TYPO3com voted on patch set 5 V +1 03/14/19, 22:55 Completed build in 13m 26s on Thu, 14 Mar, 11:55 PM Test Summary: 47182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32742
-
Georg Ringer voted on patch set 5 V +1 CR +1 03/15/19, 13:25
-
Benjamin Franzke uploaded patch set 6 03/15/19, 16:38
-
Benjamin Franzke voted on patch set 6 CR +1 03/15/19, 16:48
-
TYPO3com voted on patch set 6 V +1 03/15/19, 16:52 Completed build in 13m 47s on Fri, 15 Mar, 05:52 PM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32771
-
Stephan Großberndt voted on patch set 6 CR +1 03/15/19, 16:56
-
Benjamin Franzke voted on patch set 6 V +1 03/16/19, 06:24
-
Georg Ringer voted on patch set 6 V +2 CR +2 03/16/19, 06:30
-
Georg Ringer merged patch set 7 03/16/19, 06:30