Review main Merged

60234[TASK] Use native idn functionality

Benni Mack CR +2 V +2 Hard +182 −156 updated 03/16/19, 06:30

Commit message

It is safe to use idn_to_ascii() these days
due to symfony's polyfill functionality.

This allows us to remove the dependency
"algo26-matthias/idna-convert".

Also, all other places now use the native
idn_to_ascii() call, which could speed up
performance.

The wrapper call GeneralUtility::idnaEncode()
can then safely be deprecated.

used composer command:
  composer remove algo26-matthias/idna-convert

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Stephan Großberndt +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 13

Review log 2430

Show 45 earlier messages
  1. Benni Mack uploaded patch set 1 03/13/19, 08:15

  2. Stephan Großberndt marked it work in progress 03/13/19, 08:28

  3. TYPO3com voted on patch set 1 V +1 03/13/19, 08:29 Completed build in 13m 31s on Wed, 13 Mar, 09:29 AM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32689

  4. Benni Mack uploaded patch set 2 03/13/19, 08:41

  5. Benni Mack commented on patch set 2 03/13/19, 08:42

    This change is ready for review.
  1. Stephan Großberndt commented on patch set 2 03/13/19, 08:50

    Since we are in master "breaking" mode anyway, should we handle the removal as potentially breaking with an according "Breaking" RST instead of "Important"?
  2. Benni Mack commented on patch set 2 03/13/19, 08:51

    In the past, we did not consider third-party packages as part of the API. So I consider it non-breaking.
  3. TYPO3com voted on patch set 2 V -1 03/13/19, 08:55 Completed build in 13m 44s on Wed, 13 Mar, 09:55 AM Test Summary: 36 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32690

  4. Benni Mack uploaded patch set 3 03/13/19, 09:00

  5. TYPO3com voted on patch set 3 V +1 03/13/19, 09:14 Completed build in 13m 20s on Wed, 13 Mar, 10:14 AM Test Summary: 47182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32691

  6. Oliver Hader commented on patch set 3 03/13/19, 09:50

    Probably there is one aspect we should enforce... it's about IDN 2003 vs. 2008 and others. Example: "fußball.de" should be "xn--fuball-cta.de", and not "fussball.de" (which it would be using IDN 2003)
  7. Oliver Hader commented on patch set 3 03/13/19, 09:51

  8. Benni Mack commented on patch set 3 03/13/19, 10:31

    > Patch Set 3: > > Probably there is one aspect we should enforce... it's about IDN 2003 vs. 2008 and others. > Example: "fußball.de" should be "xn--fuball-cta.de", and not "fussball.de" (which it would be using IDN 2003) I already documented this in the RST files. On top, IDN_2003 is deprecated since PHP 7.2 so this will trigger warnings if used in third-party extensions.
  9. Stephan Großberndt voted on patch set 3 CR +1 03/13/19, 20:21

  10. Susi Moog commented on patch set 3 03/14/19, 07:19

    GeneralUtility.php:884

    idn_to_ascii

    Deprecation-87894-GeneralUtilityidnaEncode.rst:34

    should we add a hint, that for email addresses they could split the domain part or is that too obvious?

    Important-87894-RemovedPHPDependencyAlgo26-matthiasidna-convert.rst:14

    add name?
  11. Stephan Großberndt commented on patch set 4 03/14/19, 20:12

    Published edit on patch set 3.
  12. Stephan Großberndt commented on patch set 4 CR +1 03/14/19, 20:12

    GeneralUtility.php:884 Reply

    Done

    Deprecation-87894-GeneralUtilityidnaEncode.rst:34 Reply

    Done

    Important-87894-RemovedPHPDependencyAlgo26-matthiasidna-convert.rst:14 Reply

    Done
  13. TYPO3com voted on patch set 4 V +1 03/14/19, 20:28 Completed build in 15m 30s on Thu, 14 Mar, 09:28 PM Test Summary: 47182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32737

  14. Georg Ringer commented on patch set 4 03/14/19, 22:00

    PageLinkBuilder.php:472

    should there be a type cast?
  15. Stephan Großberndt commented on patch set 5 03/14/19, 22:42

    Published edit on patch set 4.
  16. Stephan Großberndt commented on patch set 5 CR +1 03/14/19, 22:42

    PageLinkBuilder.php:472 Reply

    Done
  17. TYPO3com voted on patch set 5 V +1 03/14/19, 22:55 Completed build in 13m 26s on Thu, 14 Mar, 11:55 PM Test Summary: 47182 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32742

  18. Georg Ringer voted on patch set 5 V +1 CR +1 03/15/19, 13:25

  19. Benjamin Franzke uploaded patch set 6 03/15/19, 16:38

  20. Benjamin Franzke voted on patch set 6 CR +1 03/15/19, 16:48

  21. TYPO3com voted on patch set 6 V +1 03/15/19, 16:52 Completed build in 13m 47s on Fri, 15 Mar, 05:52 PM Test Summary: 47197 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32771

  22. Stephan Großberndt voted on patch set 6 CR +1 03/15/19, 16:56

  23. Benjamin Franzke voted on patch set 6 V +1 03/16/19, 06:24

  24. Georg Ringer voted on patch set 6 V +2 CR +2 03/16/19, 06:30

  25. Georg Ringer merged patch set 7 03/16/19, 06:30