60235[BUGFIX] Restore tree nodes after search, update selected node
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1314
-
Wolfgang Klinger uploaded patch set 1 03/13/19, 11:29
-
TYPO3com voted on patch set 1 V +1 03/13/19, 11:43 Completed build in 13m 24s on Wed, 13 Mar, 12:43 PM Test Summary: 47200 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-32692
-
Guido Schmechel commented on patch set 1 V -1 03/13/19, 22:02
I don't know why, but I don't see the X icon in the input field anymore. Can you reproduce that? -
Wolfgang Klinger commented on patch set 1 03/14/19, 06:14
There is none, see issue https://forge.typo3.org/issues/87888 (that's another already pending patch) -
Guido Schmechel commented on patch set 1 V +1 03/14/19, 07:58
OK. Then the main functionality is given :-) -
Tymoteusz Motylewski commented on patch set 1 03/23/19, 21:40
Hi Thanks for the patch. Is it necessary to save the current tree state to db as an additional variable? Afaik the state of the tree (expanded/collapsed) is updated on every change, so maybe we can use this already persisted state instead of introducing new one? -
Gianluigi Martino commented on patch set 1 V +1 04/29/19, 11:36
This one is really annoying, would be nice to have it in the next release. -
Sven Juergens voted on patch set 1 V +1 07/03/19, 20:39
-
Julian Geils voted on patch set 1 V +1 07/11/19, 06:30
-
Thomas Anders commented on patch set 1 V +1 08/02/19, 21:35
Works like expected. The last state is restored after deleting the filter. If a found page is clicked and active, the correct node is opened. -
Frank Nägler voted on patch set 1 V +1 CR +1 08/06/19, 12:48
-
Andreas Kienast commented on patch set 1 V -1 08/06/19, 15:07
There is a measurable performance impact when a search is started. I will check whether this is somehow solvable. -
Andreas Kienast commented on patch set 1 CR -1 08/06/19, 15:14
PageTreeToolbar.js:309UnresolvedThis call executes an AJAX request *per node*. This solves the question about the performance impact and is deadly on large trees. -
Andreas Kienast abandoned the change 08/30/19, 08:00
I will come up with another approach